Feature/odlc search grid #62
Conversation
cmspencer109
added
ODLC
| """ | ||
|
|
||
| for path in search_paths: | ||
| x, y = [], [] |
There was a problem hiding this comment.
Don't forget your type hints; label what exactly these two lists are and what they contain, similar in format to the return type in your docstring.
| An updated dictionary with additional keys and values with utm data | ||
| """ | ||
|
|
||
| utm_coords = utm.from_latlon(coords["latitude"], coords["longitude"]) |
There was a problem hiding this comment.
Please have a type hint for this new structure, stating if its a list, what it contains, etc.
| poly_points = [(point["utm_x"], point["utm_y"]) for point in search_area_points] | ||
| boundary_shape = Polygon(poly_points) | ||
|
|
||
| search_paths = [] |
There was a problem hiding this comment.
You already know; type hints for this new list
| """ | ||
|
|
||
| # convert to shapely polygon for buffer operations | ||
| poly_points = [(point["utm_x"], point["utm_y"]) for point in search_area_points] |
There was a problem hiding this comment.
Type hint for this guy as well
|
|
||
| # convert to shapely polygon for buffer operations | ||
| poly_points = [(point["utm_x"], point["utm_y"]) for point in search_area_points] | ||
| boundary_shape = Polygon(poly_points) |
There was a problem hiding this comment.
Python will also support a type hint of an object from an imported module, I know this seems redundant since the function is literally called Polygon, however you still need a type hint for the object you create here.
|
|
||
| Parameters | ||
| ---------- | ||
| search_area_points : Dict[str, float] |
There was a problem hiding this comment.
The parameter says that this is a List[Dict[str, float]], I think you forgot the first List[]
| @@ -25,8 +29,13 @@ | |||
| search_area_points = search_path.all_latlon_to_utm(search_area_points) | |||
|
|
|||
| # Generate search path | |||
| buffer_distance = -50 | |||
| search_paths = search_path.generate_search_path(search_area_points, buffer_distance) | |||
| BUFFER_DISTANCE = -50 # use height/2 of camera image as buffer distance | |||
There was a problem hiding this comment.
This constant needs a type hint.
This feature is to add the ability for the drone to cover an entire search area by flying consecutively smaller paths of the original boundary shape. The idea is that the drone will start on the outer path, fly it, and then once it reaches it's starting point, move to the next path in the list.
Specifically, the function generate_search_paths() should be passed the original bounding search area, and a buffer distance (equal to height of the camera coverage on the ground divided by 2). The function returns a list of search paths, where each search path is a list of coordinate tuples.
This feature only generates the paths. Flying them in an orderly manner will be handled elsewhere.