Add AS5600 #2
Merged
Add AS5600 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If the library change can't be merged, try importing the symbol yourself: |
|
Make sure you link the datasheet in the symbol: |
OcelotEmpire
requested changes
Oct 2, 2024
There was a problem hiding this comment.
I guess I should post this as a review instead of a comment...
Make sure you link the datasheet in the symbol:
Symbol Editor -> Filter: AS5600 -> Symbol Properties (triangle with gear on the top bar) -> datasheet -> paste in the link
Also just a nitpick but we usually make the symbol's origin in the center-ish instead of the top left corner
Signed-off-by: Brendan Westley <[email protected]>
Signed-off-by: Brendan Westley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ams-osram.com/products/sensors/position-sensors/ams-as5600-position-sensor
Added schematic symbol:
Datasheet ref:
The master branch is protected so I had to create a new branch to make this change.