fix: bug with negative length #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
len < 0 is always false, because len is a uint and uint can never be negative. The original C version casts to int here, so that the uint is converted to 2's compliment negative numbers.
miwarnec
force-pushed
the
master
branch
2 times, most recently
from
a947b8e to
a27aad4
Compare
miwarnec
force-pushed
the
master
branch
2 times, most recently
from
db25142 to
953511f
Compare
miwarnec
force-pushed
the
master
branch
2 times, most recently
from
200d29c to
cd81abb
Compare
miwarnec
force-pushed
the
master
branch
3 times, most recently
from
6f47d9c to
6900bf2
Compare
miwarnec
force-pushed
the
master
branch
2 times, most recently
from
b31337a to
38b3ac4
Compare
miwarnec
pushed a commit
that referenced
this pull request
Jan 6, 2022
|
fixed on master. original kcp only had one (int) cast, not two |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
len < 0 is always false, because len is a uint and uint can never be negative.
The original C version casts to int here, so that the uint is converted to 2's compliment negative numbers.