-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add way of working for leaving laptops unattended #258
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am missing the assumptions and consequences in this ADR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
docs/adrs/0017-laptop-security.md
Outdated
|
||
## Decision | ||
|
||
Whenever a colleague will find your laptop open and unlocked, they will message in the `random` Mattermost channel of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whenever a colleague will find your laptop open and unlocked, they will message in the `random` Mattermost channel of | |
Whenever a colleague will find your laptop open, unlocked, and unattended, they will message in the `random` Mattermost channel of |
Does not feel like an Architectural Decision record to me... |
I believe this is about choosing social architecture over technical controls to enforce security - that's a system-wide architectural pattern worth documenting, even if the implementation involves cookies ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small minor detail
I do not agree to this ADR and will not participate. Feels like a sorority rule/club. |
@anneschuth , i do not think the way you and i look at ADRs are the same. In many documents written by thought leaders in software engineering it is very clear that an architectural decision records is related to software architecture and documenting matter-full decisions on the things that matter in a software project. I have never seen anyone talk about social architecture and ADRs. do you have any material to support your ideas? I love this talk from martin folwer on software architecture: https://www.youtube.com/watch?v=DngAZyWMGR0 |
Will be migrated to way-of-working |
1342b9f
|
||
## Decision | ||
|
||
Whenever a colleague will find your laptop open, unlocked, and unattended, they will message in the `random` Mattermost |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not agree publishing these things in random. Feels to me like bashing a collegue in public. Why not just give a warning to the person in real live?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree; you can, for example, open a document on the laptop and leave some kind of comment. This way, the person will also know that the laptop was left unattended without public bashing.
Yeah, you're probably right. I'm more or less treating ADRs as if they're RFCs (which they are not, RFCs are broader). I guess in my mind this was on the border, but I get your point of view as well. Good that it is moving to WoW! |
Description
Please include a summary of the changes and the related issue.
Checklist
Please check all the boxes that apply to this pull request using "x":
Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1
Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.