Add support for file inputs to snaps-jest
#2494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
Mrtenz
force-pushed
the
mrtenz/snaps-jest-file-inputs
branch
from
f2a04bd
to
afa01aa
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2494 +/- ##
==========================================
+ Coverage 94.36% 94.38% +0.02%
==========================================
Files 441 441
Lines 9068 9106 +38
Branches 1396 1405 +9
==========================================
+ Hits 8557 8595 +38
Misses 511 511 ☔ View full report in Codecov by Sentry. |
Mrtenz
force-pushed
the
mrtenz/snaps-jest-file-inputs
branch
from
c1f38b8
to
d426571
Compare
| id, | ||
| ); | ||
|
|
||
| const fileObject = await getFileToUpload(file, options); |
There was a problem hiding this comment.
We should reject files that are too large here, similar to how we will have to do in the client
Mrtenz
force-pushed
the
mrtenz/snaps-jest-file-inputs
branch
from
d426571
to
f68c22e
Compare
FrederikBolding
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new method
uploadFileto the interface object returned bysnaps-jest, to "upload" a file to the Snap. This simulates the file input component.