Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metadata to interface state #2503

Closed
wants to merge 3 commits into from
Closed

Conversation

Mrtenz
Copy link
Member

@Mrtenz Mrtenz commented Jun 20, 2024

This refactors the SnapInterfaceController's state to include metadata together with the state value. Currently the only metadata is the type, i.e., Dropdown, FileInput, Form, Input. Right now this is mainly required to properly map state to an object with files and values, which is required for #2494.

@Mrtenz
Copy link
Member Author

Mrtenz commented Jun 20, 2024

@metamaskbot update-pr

Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.38%. Comparing base (ea36386) to head (8b92da6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2503      +/-   ##
==========================================
+ Coverage   94.36%   94.38%   +0.01%     
==========================================
  Files         441      441              
  Lines        9068     9095      +27     
  Branches     1396     1402       +6     
==========================================
+ Hits         8557     8584      +27     
  Misses        511      511              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Mrtenz Mrtenz marked this pull request as ready for review June 20, 2024 08:42
@Mrtenz Mrtenz requested a review from a team as a code owner June 20, 2024 08:42
@Mrtenz
Copy link
Member Author

Mrtenz commented Jun 20, 2024

We decided to not do this for now.

@Mrtenz Mrtenz closed this Jun 20, 2024
@Mrtenz Mrtenz deleted the mrtenz/interface-state-metadata branch June 20, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants