chore: update accounts related packages #27284

ccharly · 2024-09-19T14:07:02Z

Description

Updating packages to use versions coming from the new accounts monorepo.

Related issues

Related to:

Manual testing steps

Test parts of the extension that closely related to accounts management + HW wallets support.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-09-19T14:07:19Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-09-19T14:07:56Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected]	network	`0`	992 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	266 kB	metamaskbot
npm/@metamask/[email protected]	network	`0`	1.02 MB	metamaskbot
npm/@metamask/[email protected]	None	`0`	167 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	84.5 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	177 kB	metamaskbot
npm/@metamask/[email protected]	None	`0`	88.5 kB	metamaskbot
npm/@metamask/[email protected]	network	`0`	2.12 MB	danfinlay, gudahtt, kumavis, ...8 more

🚮 Removed packages: npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected], npm/@metamask/[email protected]

View full report↗︎

socket-security · 2024-09-19T14:07:57Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

metamaskbot · 2024-09-24T10:14:18Z

Builds ready [36456ee]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1775 ± 112 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	271	2322	1701	402	193
		domContentLoaded	1478	2300	1748	231	111
		load	1539	2326	1775	234	112
		domInteractive	21	155	47	33	16

Bundle size diffs [🚀 Bundle size reduced!]

background: 318 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: -72.32 KiB (-0.89%)

metamaskbot · 2024-09-24T19:27:39Z

Builds ready [169140b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1973 ± 88 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1651	2507	1965	187	90
		domContentLoaded	1644	2451	1936	180	87
		load	1704	2499	1973	183	88
		domInteractive	15	101	50	25	12

Bundle size diffs [🚀 Bundle size reduced!]

background: 318 Bytes (0.01%)
ui: 0 Bytes (0.00%)
common: -72.34 KiB (-0.89%)

metamaskbot · 2024-09-25T21:40:22Z

Builds ready [c991601]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1649 ± 65 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	276	1919	1574	327	157
		domContentLoaded	1415	1853	1625	128	62
		load	1418	1878	1649	136	65
		domInteractive	21	200	55	46	22

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: -73.43 KiB (-0.90%)

metamaskbot · 2024-09-26T09:10:41Z

Builds ready [720cf81]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2014 ± 92 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	516	2542	1955	375	180
		domContentLoaded	1676	2425	1981	170	82
		load	1680	2549	2014	191	92
		domInteractive	16	121	51	24	11

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: -73.43 KiB (-0.90%)

metamaskbot · 2024-09-27T09:02:12Z

Builds ready [0f337dc]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2139 ± 89 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	313	2538	1969	526	253
		domContentLoaded	1773	2525	2112	176	84
		load	1783	2602	2139	185	89
		domInteractive	27	121	52	22	11

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 1.18 KiB (0.01%)

package.json

metamaskbot · 2024-09-27T13:21:22Z

Builds ready [8a913b9]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2152 ± 105 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	672	2455	2073	393	189
		domContentLoaded	1623	2415	2123	218	105
		load	1663	2422	2152	219	105
		domInteractive	22	83	45	18	9

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 1.18 KiB (0.01%)

ccharly · 2024-09-30T07:42:39Z

test/e2e/tests/metrics/state-snapshots/errors-after-init-opt-in-background-state.json

-          "1": "string",
-          "2": "string"
-        }
+        "srcNetworkAllowlist": { "0": "string", "1": "string", "2": "string" },


IDK why this got pretty-print differently, maybe our prettier/eslint config got updated. Anyway, the CI is happy with that change :)

sonarcloud · 2024-10-04T16:47:23Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-10-04T17:15:43Z

Builds ready [1f2da0a]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1848 ± 117 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	1535	2320	1854	241	116
		domContentLoaded	1490	2291	1829	238	114
		load	1497	2325	1848	243	117
		domInteractive	21	175	57	41	20

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 0 Bytes (0.00%)
common: 1.18 KiB (0.02%)

plasmacorral · 2024-10-04T21:15:05Z

Tested commit 1fdad0a with Chrome 129 and Firefox 131 in mac sonoma 14.6.1

Tested migration in Chrome from 11.16.16 to 1fdad0a
Tested migration in Firefox from 12.3.0 to 1fdad0a

Was able to add HD accounts, import pk, remove accounts, add hardware, remove hardware account, forget hardware, add and remove SSK accounts, sign, send, lock and unlock, pin and hide accounts, dapp connect.

Also tested fresh install with create new wallet and restore SRP.

ccharly added the team-accounts label Sep 19, 2024

ccharly self-assigned this Sep 19, 2024

ccharly force-pushed the chore/update-accounts-packages branch 6 times, most recently from 8bd75b4 to afb0da7 Compare September 24, 2024 08:39

ccharly mentioned this pull request Sep 24, 2024

chore: update 'eth-{simple,hd,snap}-keyring' + 'keyring-api' MetaMask/core#4713

Merged

3 tasks

ccharly force-pushed the chore/update-accounts-packages branch 2 times, most recently from b02fbc2 to 169140b Compare September 24, 2024 18:33

ccharly force-pushed the chore/update-accounts-packages branch 3 times, most recently from af8589c to c991601 Compare September 25, 2024 21:09

ccharly force-pushed the chore/update-accounts-packages branch from c991601 to aa53ef3 Compare September 26, 2024 07:50

ccharly added 2 commits September 26, 2024 10:39

chore: update accounts related packages

3d68730

test(metrics): update snapshots

720cf81

ccharly force-pushed the chore/update-accounts-packages branch from aa53ef3 to 720cf81 Compare September 26, 2024 08:39

ccharly marked this pull request as ready for review September 26, 2024 09:01

ccharly requested review from a team as code owners September 26, 2024 09:01

ccharly added the needs-qa Label will automate into QA workspace label Sep 26, 2024

chore: update snap watch-only to version 4.1.1

1fea8f6

test: update SSK info in mock-state.json

0f337dc

danroc reviewed Sep 27, 2024

View reviewed changes

package.json Outdated Show resolved Hide resolved

fix: fix missing ^ for transaction-controller

8a913b9

danroc previously approved these changes Sep 27, 2024

View reviewed changes

plasmacorral self-assigned this Sep 27, 2024

plasmacorral added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Sep 27, 2024

ccharly commented Sep 30, 2024

View reviewed changes

montelaidev previously approved these changes Sep 30, 2024

View reviewed changes

ccharly removed the request for review from a team September 30, 2024 07:58

Merge branch 'develop' into chore/update-accounts-packages

1f2da0a

ccharly dismissed stale reviews from montelaidev and danroc via 1f2da0a October 4, 2024 16:35

plasmacorral added QA Passed and removed needs-qa Label will automate into QA workspace labels Oct 4, 2024

danroc approved these changes Oct 7, 2024

View reviewed changes

montelaidev approved these changes Oct 7, 2024

View reviewed changes

ccharly added this pull request to the merge queue Oct 7, 2024

Merged via the queue into develop with commit e354ad5 Oct 7, 2024
79 of 80 checks passed

ccharly deleted the chore/update-accounts-packages branch October 7, 2024 08:09

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Oct 7, 2024

github-actions bot locked and limited conversation to collaborators Oct 7, 2024

metamaskbot added the release-12.7.0 Issue or pull request that will be included in release 12.7.0 label Oct 7, 2024

gauthierpetetin added release-12.6.0 Issue or pull request that will be included in release 12.6.0 and removed release-12.7.0 Issue or pull request that will be included in release 12.7.0 labels Oct 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update accounts related packages #27284

chore: update accounts related packages #27284

ccharly commented Sep 19, 2024 •

edited

Loading

github-actions bot commented Sep 19, 2024

socket-security bot commented Sep 19, 2024 •

edited

Loading

socket-security bot commented Sep 19, 2024 •

edited

Loading

metamaskbot commented Sep 24, 2024

metamaskbot commented Sep 24, 2024

metamaskbot commented Sep 25, 2024

metamaskbot commented Sep 26, 2024

metamaskbot commented Sep 27, 2024

metamaskbot commented Sep 27, 2024

ccharly Sep 30, 2024

sonarcloud bot commented Oct 4, 2024

metamaskbot commented Oct 4, 2024

plasmacorral commented Oct 4, 2024 •

edited

Loading

chore: update accounts related packages #27284

chore: update accounts related packages #27284

Conversation

ccharly commented Sep 19, 2024 • edited Loading

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Sep 19, 2024

socket-security bot commented Sep 19, 2024 • edited Loading

socket-security bot commented Sep 19, 2024 • edited Loading

metamaskbot commented Sep 24, 2024

metamaskbot commented Sep 24, 2024

metamaskbot commented Sep 25, 2024

metamaskbot commented Sep 26, 2024

metamaskbot commented Sep 27, 2024

metamaskbot commented Sep 27, 2024

ccharly Sep 30, 2024

Choose a reason for hiding this comment

sonarcloud bot commented Oct 4, 2024

Quality Gate passed

metamaskbot commented Oct 4, 2024

plasmacorral commented Oct 4, 2024 • edited Loading

ccharly commented Sep 19, 2024 •

edited

Loading

socket-security bot commented Sep 19, 2024 •

edited

Loading

socket-security bot commented Sep 19, 2024 •

edited

Loading

plasmacorral commented Oct 4, 2024 •

edited

Loading