Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update 'eth-{simple,hd,snap}-keyring' + 'keyring-api' #4713

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

ccharly
Copy link
Contributor

@ccharly ccharly commented Sep 18, 2024

Explanation

Those new versions have been created using the new accounts monorepo.

We are updating them to make sure this new way of building those packages has no unintended side-effects.

References

Related to:

Changelog

@metamask/keyring-controller

  • CHANGED: Bump @metamask/eth-hd-keyring to ^7.0.3
  • CHANGED: Bump @metamask/eth-simple-keyring to ^6.0.4
  • CHANGED: Bump @metamask/keyring-api to ^8.1.2

@metamask/accounts-controller

  • CHANGED: Bump @metamask/eth-snap-keyring to ^4.3.5
  • CHANGED: Bump @metamask/keyring-api to ^8.1.2

@metamask/assets-controller

  • CHANGED: Bump @metamask/keyring-api to ^8.1.2

@metamask/chain-controller

  • CHANGED: Bump @metamask/keyring-api to ^8.1.2

@metamask/transaction-controller

  • CHANGED: Bump @metamask/keyring-api to ^8.1.2

@metamask/profile-sync-controller

  • CHANGED: Bump @metamask/keyring-api to ^8.1.2

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@ccharly ccharly force-pushed the feature/use-new-accounts-packages branch from 56326ab to 067f2f0 Compare September 18, 2024 15:59
@ccharly
Copy link
Contributor Author

ccharly commented Sep 19, 2024

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.1-preview-067f2f06",
  "@metamask-previews/address-book-controller": "6.0.1-preview-067f2f06",
  "@metamask-previews/announcement-controller": "7.0.1-preview-067f2f06",
  "@metamask-previews/approval-controller": "7.0.4-preview-067f2f06",
  "@metamask-previews/assets-controllers": "38.0.1-preview-067f2f06",
  "@metamask-previews/base-controller": "7.0.1-preview-067f2f06",
  "@metamask-previews/build-utils": "3.0.1-preview-067f2f06",
  "@metamask-previews/chain-controller": "0.1.2-preview-067f2f06",
  "@metamask-previews/composable-controller": "9.0.1-preview-067f2f06",
  "@metamask-previews/controller-utils": "11.3.0-preview-067f2f06",
  "@metamask-previews/ens-controller": "14.0.1-preview-067f2f06",
  "@metamask-previews/eth-json-rpc-provider": "4.1.4-preview-067f2f06",
  "@metamask-previews/gas-fee-controller": "20.0.1-preview-067f2f06",
  "@metamask-previews/json-rpc-engine": "9.0.3-preview-067f2f06",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.3-preview-067f2f06",
  "@metamask-previews/keyring-controller": "17.2.1-preview-067f2f06",
  "@metamask-previews/logging-controller": "6.0.1-preview-067f2f06",
  "@metamask-previews/message-manager": "10.1.1-preview-067f2f06",
  "@metamask-previews/name-controller": "8.0.1-preview-067f2f06",
  "@metamask-previews/network-controller": "21.0.1-preview-067f2f06",
  "@metamask-previews/notification-controller": "6.0.1-preview-067f2f06",
  "@metamask-previews/notification-services-controller": "0.7.0-preview-067f2f06",
  "@metamask-previews/permission-controller": "11.0.2-preview-067f2f06",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-067f2f06",
  "@metamask-previews/phishing-controller": "12.0.3-preview-067f2f06",
  "@metamask-previews/polling-controller": "10.0.1-preview-067f2f06",
  "@metamask-previews/preferences-controller": "13.0.3-preview-067f2f06",
  "@metamask-previews/profile-sync-controller": "0.8.0-preview-067f2f06",
  "@metamask-previews/queued-request-controller": "5.0.1-preview-067f2f06",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-067f2f06",
  "@metamask-previews/selected-network-controller": "18.0.1-preview-067f2f06",
  "@metamask-previews/signature-controller": "19.1.0-preview-067f2f06",
  "@metamask-previews/transaction-controller": "37.0.0-preview-067f2f06",
  "@metamask-previews/user-operation-controller": "15.0.1-preview-067f2f06"
}

@ccharly ccharly force-pushed the feature/use-new-accounts-packages branch from 067f2f0 to bff78ca Compare September 19, 2024 09:47
@ccharly
Copy link
Contributor Author

ccharly commented Sep 19, 2024

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.1-preview-bff78ca",
  "@metamask-previews/address-book-controller": "6.0.1-preview-bff78ca",
  "@metamask-previews/announcement-controller": "7.0.1-preview-bff78ca",
  "@metamask-previews/approval-controller": "7.0.4-preview-bff78ca",
  "@metamask-previews/assets-controllers": "38.0.1-preview-bff78ca",
  "@metamask-previews/base-controller": "7.0.1-preview-bff78ca",
  "@metamask-previews/build-utils": "3.0.1-preview-bff78ca",
  "@metamask-previews/chain-controller": "0.1.2-preview-bff78ca",
  "@metamask-previews/composable-controller": "9.0.1-preview-bff78ca",
  "@metamask-previews/controller-utils": "11.3.0-preview-bff78ca",
  "@metamask-previews/ens-controller": "14.0.1-preview-bff78ca",
  "@metamask-previews/eth-json-rpc-provider": "4.1.4-preview-bff78ca",
  "@metamask-previews/gas-fee-controller": "20.0.1-preview-bff78ca",
  "@metamask-previews/json-rpc-engine": "9.0.3-preview-bff78ca",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.3-preview-bff78ca",
  "@metamask-previews/keyring-controller": "17.2.1-preview-bff78ca",
  "@metamask-previews/logging-controller": "6.0.1-preview-bff78ca",
  "@metamask-previews/message-manager": "10.1.1-preview-bff78ca",
  "@metamask-previews/name-controller": "8.0.1-preview-bff78ca",
  "@metamask-previews/network-controller": "21.0.1-preview-bff78ca",
  "@metamask-previews/notification-controller": "6.0.1-preview-bff78ca",
  "@metamask-previews/notification-services-controller": "0.7.0-preview-bff78ca",
  "@metamask-previews/permission-controller": "11.0.2-preview-bff78ca",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-bff78ca",
  "@metamask-previews/phishing-controller": "12.0.3-preview-bff78ca",
  "@metamask-previews/polling-controller": "10.0.1-preview-bff78ca",
  "@metamask-previews/preferences-controller": "13.0.3-preview-bff78ca",
  "@metamask-previews/profile-sync-controller": "0.8.0-preview-bff78ca",
  "@metamask-previews/queued-request-controller": "5.0.1-preview-bff78ca",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-bff78ca",
  "@metamask-previews/selected-network-controller": "18.0.1-preview-bff78ca",
  "@metamask-previews/signature-controller": "19.1.0-preview-bff78ca",
  "@metamask-previews/transaction-controller": "37.0.0-preview-bff78ca",
  "@metamask-previews/user-operation-controller": "15.0.1-preview-bff78ca"
}

@ccharly ccharly force-pushed the feature/use-new-accounts-packages branch 2 times, most recently from 1bea6e0 to 40bcceb Compare September 23, 2024 09:19
@ccharly ccharly force-pushed the feature/use-new-accounts-packages branch from 40bcceb to 4968a25 Compare September 23, 2024 09:28
@ccharly
Copy link
Contributor Author

ccharly commented Sep 23, 2024

@metamaskbot publish-preview

Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/accounts-controller": "18.2.1-preview-4968a25",
  "@metamask-previews/address-book-controller": "6.0.1-preview-4968a25",
  "@metamask-previews/announcement-controller": "7.0.1-preview-4968a25",
  "@metamask-previews/approval-controller": "7.0.4-preview-4968a25",
  "@metamask-previews/assets-controllers": "38.0.1-preview-4968a25",
  "@metamask-previews/base-controller": "7.0.1-preview-4968a25",
  "@metamask-previews/build-utils": "3.0.1-preview-4968a25",
  "@metamask-previews/chain-controller": "0.1.2-preview-4968a25",
  "@metamask-previews/composable-controller": "9.0.1-preview-4968a25",
  "@metamask-previews/controller-utils": "11.3.0-preview-4968a25",
  "@metamask-previews/ens-controller": "14.0.1-preview-4968a25",
  "@metamask-previews/eth-json-rpc-provider": "4.1.4-preview-4968a25",
  "@metamask-previews/gas-fee-controller": "20.0.1-preview-4968a25",
  "@metamask-previews/json-rpc-engine": "9.0.3-preview-4968a25",
  "@metamask-previews/json-rpc-middleware-stream": "8.0.3-preview-4968a25",
  "@metamask-previews/keyring-controller": "17.2.1-preview-4968a25",
  "@metamask-previews/logging-controller": "6.0.1-preview-4968a25",
  "@metamask-previews/message-manager": "10.1.1-preview-4968a25",
  "@metamask-previews/name-controller": "8.0.1-preview-4968a25",
  "@metamask-previews/network-controller": "21.0.1-preview-4968a25",
  "@metamask-previews/notification-controller": "6.0.1-preview-4968a25",
  "@metamask-previews/notification-services-controller": "0.8.0-preview-4968a25",
  "@metamask-previews/permission-controller": "11.0.2-preview-4968a25",
  "@metamask-previews/permission-log-controller": "3.0.1-preview-4968a25",
  "@metamask-previews/phishing-controller": "12.0.3-preview-4968a25",
  "@metamask-previews/polling-controller": "10.0.1-preview-4968a25",
  "@metamask-previews/preferences-controller": "13.0.3-preview-4968a25",
  "@metamask-previews/profile-sync-controller": "0.8.1-preview-4968a25",
  "@metamask-previews/queued-request-controller": "5.0.1-preview-4968a25",
  "@metamask-previews/rate-limit-controller": "6.0.1-preview-4968a25",
  "@metamask-previews/selected-network-controller": "18.0.1-preview-4968a25",
  "@metamask-previews/signature-controller": "19.1.0-preview-4968a25",
  "@metamask-previews/transaction-controller": "37.0.0-preview-4968a25",
  "@metamask-previews/user-operation-controller": "15.0.1-preview-4968a25"
}

@ccharly ccharly marked this pull request as ready for review September 24, 2024 10:06
@ccharly ccharly requested review from a team as code owners September 24, 2024 10:06
@ccharly ccharly self-assigned this Sep 24, 2024
@ccharly ccharly force-pushed the feature/use-new-accounts-packages branch from d09e6f9 to 2e2cf11 Compare September 24, 2024 10:21
@danroc danroc changed the title chore: update eth-{simple,hd,snap}-keyring + keyring-api chore: update 'eth-{simple,hd,snap}-keyring' + 'keyring-api' Sep 24, 2024
@ccharly ccharly merged commit 599ac25 into main Sep 24, 2024
116 checks passed
@ccharly ccharly deleted the feature/use-new-accounts-packages branch September 24, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants