test: remove unused test #4703
Merged
test: remove unused test #4703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prithpal-Sooriya
added
the
team-notifications
3 tasks
Prithpal-Sooriya
force-pushed
the
notifications/remove-unused-mock
branch
from
eb4bc37
to
8f59e12
Compare
| @@ -1512,17 +1512,9 @@ function mockUserStorageMessenger(options?: { | |||
| return mockAccountsUpdateAccountMetadata(args.slice(1)); | |||
| } | |||
|
|
|||
| if (actionType === 'AccountsController:getAccountByAddress') { | |||
There was a problem hiding this comment.
This action does not exist - we are not using this anymore:
mathieuartu
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
We have a mock and a test that is not used anymore. It still passed the CI, but actually doesn't test anything.
References
Changelog
@metamask/profile-sync-controllerChecklist