feat: add main network sync controller integration #4701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prithpal-Sooriya
force-pushed
the
NOTIFY-1094/network-main-sync-integration
branch
2 times, most recently
from
f13a7c1
to
d2c8267
Compare
I need to add some integration tests to be a bit more confident in outcome
I need to add some integration tests to be a bit more confident in outcome
…ork-main-sync-integration
Prithpal-Sooriya
added
the
team-notifications
packages/profile-sync-controller/src/controllers/user-storage/UserStorageController.test.ts
Outdated
Show resolved
Hide resolved
| // TODO: add external NetworkController event | ||
| // Need to listen for when a network gets added | ||
| // TODO - replace shimmed interface with actual interfaces once merged | ||
| // Waiting on #4698 |
There was a problem hiding this comment.
For visibility: #4698
…ork-main-sync-integration
…m:MetaMask/core into NOTIFY-1094/network-main-sync-integration
…ork-main-sync-integration
…ork-main-sync-integration
mostly to be used for analytics
Prithpal-Sooriya
force-pushed
the
NOTIFY-1094/network-main-sync-integration
branch
from
165b70e
to
94a67ba
Compare
…ork-main-sync-integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This adds the main network sync method to the
UserStorageController. It also connects theNetworkControllerevents and actions used for network syncing.References
https://consensyssoftware.atlassian.net/browse/NOTIFY-1094
Changelog
@metamask/profile-sync-controllersyncNetworksmethod used to initiate the main network syncperformMainNetworkSyncto call the NetworkController actions to get and update NetworkConfigurations.getStorageOptionsprivate method to get storage options for syncing.Checklist