WIP Switch to data time cycling to support multiple models and multiple case studies or trials #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
875fb6b
to
e89544e
Compare
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
053fe11
to
9567afb
Compare
jfrost-mo
changed the title
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
6f8722f
to
20a014d
Compare
7 tasks
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
3 times, most recently
from
2133d21
to
d6b08fe
Compare
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
8db71ca
to
3eafb43
Compare
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
c48d075
to
2636cf0
Compare
This was referenced Aug 23, 2024
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
4 times, most recently
from
b1d6ab6
to
62ec811
Compare
jfrost-mo
changed the title
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
104765a
to
8a1a8fe
Compare
|
This work is now ready to be reviewed. |
jfrost-mo
requested review from
SGallagherMet,
JorgeBornemann and
Sylviabohnenstengel
This is useful if the setting is not in the rose-suite.conf
Also add a test.
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
6f35333
to
ebc42f8
Compare
The output_dir was in the wrong place, so it was making a POST request.
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
ebc42f8
to
a0aff82
Compare
jfrost-mo
force-pushed
the
750_data_time_cycling
branch
from
5028a65
to
86a7406
Compare
This prevents needing to rely on external hosts for these. I did need to drop the example commands to fetch the resources via curl, but they were probably confusing anyway.
They are not implemented yet, and can be re-added when they are.
The operator now requires all arguments to either be numbers, or all be None if you don't want to constrain the area. The test has been mildly improved, so at least it checks for both of the named functions on the coordinates, though it still doesn't test that they do anything.
|
@SGallagherMet I think I've addressed all of your comments now. Could you give it a second look? |
|
@JorgeBornemann just needs your portability review now. For reference, the tutorial branch we are using for the workshop next week is the same as this one, minus a couple of the more recent commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #750
WIP in title is just to stop accidental merge before all three reviews.
Contribution checklist
Aim to have all relevant checks ticked off before merging. See the developer's guide for more detail.
GitHub Copilot was used in the PR.