Error when parsing variable names with spaces

[jwarner8]

Describe the bug

If variable names include spaces, CYLC cannot parse this into the workflow (spaces are not permitted).

How to reproduce

Etc. for variable "Turbulent mixing height after boundary layer", produces the following error during validation:

GraphParseError: Illegal graph node: collate_deterministic_domain_surface_histogram_series_.Turbulent mixing height after boundary layer

Expected behaviour

Could add another parser that replaces spaces with an underscore.

Environment

• Version: [e.g. from cset --version]
• Browser (if UI issue): [e.g. Chrome, Firefox]

[jfrost-mo]

This is fixed in #765, as I've added a proper task name sanitiser:

CSET/cset-workflow/lib/python/jinja_utils.py

Lines 89 to 119 in d6ef034

	def sanitise_task_name(s: str):
	"""Sanitise a string to be used as a Cylc task name.
	Rules per
	https://cylc.github.io/cylc-doc/stable/html/user-guide/writing-workflows/runtime.html#cylc.flow.unicode_rules.TaskNameValidator
	The rules for valid task and family names:
	* must start with: alphanumeric
	* can only contain: alphanumeric, _, -, +, %, @
	* cannot start with: _cylc
	* cannot be: root
	Note that actually there are a few more characters supported, see:
	https://github.com/cylc/cylc-flow/issues/6288
	"""
	# Ensure we have a string.
	if not isinstance(s, str):
	s = str(s)
	# Ensure the first character is alphanumeric.
	if not s[0].isalnum():
	s = f"sanitised_{s}"
	# Specifically replace `.` with `p`, as in 3p5.
	s = s.replace(".", "p")
	# Replace invalid characters with underscores.
	s = "".join(c if c.isalnum() or c in "-+%@" else "_" for c in s)
	# Ensure the name is not a reserved name.
	if s.lower() == "root":
	s = f"sanitised_{s}"
	# Ensure the name does not start with "_cylc".
	if s.lower().startswith("_cylc"):
	s = f"sanitised_{s}"
	return s

[jwarner8]

Nice! Upcoming fix in #765 so closing this.