Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dimension and metric filters #186

Merged
merged 2 commits into from
Apr 30, 2024
Merged

feat: add dimension and metric filters #186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6d8ff9
add dimension and metric filters
nmorvil Apr 30, 2024
01dcef3
[pre-commit.ci] auto fixes
pre-commit-ci[bot] Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion tap_google_analytics/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,14 +107,25 @@ def _lookup_data_type(self, field_type, attribute, dimensions_ref, metrics_ref):

@staticmethod
def _generate_report_definition(report_def_raw):
report_definition = {"metrics": [], "dimensions": []}
report_definition = {
"metrics": [],
"dimensions": [],
"metricFilter": None,
"dimensionFilter": None,
}

for dimension in report_def_raw["dimensions"]:
report_definition["dimensions"].append({"name": dimension})

for metric in report_def_raw["metrics"]:
report_definition["metrics"].append(Metric(name=metric))

if "metric_filter" in report_def_raw:
report_definition["metric_filter"] = report_def_raw["metric_filter"]

if "dimension_filter" in report_def_raw:
report_definition["dimension_filter"] = report_def_raw["dimension_filter"]

# Add segmentIds to the request if the stream contains them
if "segments" in report_def_raw:
report_definition["segments"] = [
Expand Down Expand Up @@ -253,6 +264,8 @@ def _query_api(self, report_definition, state_filter, pageToken=None) -> RunRepo
metrics=report_definition["metrics"],
date_ranges=[DateRange(start_date=state_filter, end_date=self.end_date)],
limit=self.page_size,
metric_filter=report_definition["metric_filter"],
dimension_filter=report_definition["dimension_filter"],
edgarrmondragon marked this conversation as resolved.
Show resolved Hide resolved
offset=(pageToken or 0) * self.page_size,
)

Expand Down