feat: add dimension and metric filters #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nmorvil
changed the title
edgarrmondragon
pushed a commit
that referenced
this pull request
May 5, 2024
This PR fixes the issue introduced by #186. It was causing the tap to break if no metric filter or dimensions are defined in the reports.json, or if these keys are defined with _camelCase_ notation, which would be reasonable given it's a JSON file and all the other dimension and metric values use _camelCase_ notation. The issue was that the keys were defined with _camelCase_ on lines 113-114 on the `client.py` file when initializing the `report_definition` dictionary, but it then tries to access them using _snake_case_ notation on lines 267-268, which caused the tap to break with an invalid key error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #47