-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow printing unit list from MM #6190
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6190 +/- ##
============================================
- Coverage 29.17% 29.17% -0.01%
- Complexity 13971 13981 +10
============================================
Files 2628 2628
Lines 266564 266641 +77
Branches 47575 47584 +9
============================================
+ Hits 77771 77792 +21
- Misses 184910 184965 +55
- Partials 3883 3884 +1 ☔ View full report in Codecov by Sentry. |
I suggest moving over the printing code from MML. That is eventually going to happen anyway. |
That's a huge refactoring. Why do you say it's something that's eventually going to happen anyway? |
because there's no reason to keep it in MML when MM can make use of it And for MML it's just a big delete and changing imports. Was on my todo list p.12 |
I'll let you work on that then, but I think it's going to be harder than just move and change imports. |
No idea when I'll get to it. Or if. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. Suggest calling the button "Print Record Sheets" or at least note this in the tooltip. It's probably not that self-evident in MM.
Edit: or maybe it is, I don't know. @HammerGS you decide and merge.
Requires MegaMek/megameklab#1656.
Adds a button to print the units of the selected player, without needing to save the list and opening it in MML:
This works by saving the unit list to a temporary file and then opening it in MML automatically.
If MegaMek and MegaMekLab are located in same directory (i.e., from a typical MekHQ distribution), MegaMek will automatically detect the MML executable and launch it. Otherwise, MegaMek will have to be told where MML is in the client settings:
This can be the actual MML executable (
MegaMekLab.exe
orMegaMekLab.sh
as appropriate) or the gradle wrapper of the MegaMekLab git repo (gradlew.bat
for windows,gradlew
otherwise). If it's a path to a MegaMekLab executable everything will function as one might expect, if it's a gradle wrapper it will try to compile and run MML from source.This allows this feature to be used even with a development version of MegaMekLab.