Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MM Scenarios: story dialogs #6157

Merged

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Oct 31, 2024

This makes story dialogs in MM scenarios (or wherever they come from) show one after the other instead of all at once. Also, when another modal dialog is up, a story dialog will be postponed until after the other dialog is closed. Only affects story dialogs.

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.18%. Comparing base (d165031) to head (7a0054f).
Report is 45 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6157      +/-   ##
============================================
- Coverage     29.18%   29.18%   -0.01%     
+ Complexity    13974    13973       -1     
============================================
  Files          2623     2623              
  Lines        266441   266444       +3     
  Branches      47594    47595       +1     
============================================
- Hits          77774    77773       -1     
- Misses       184765   184768       +3     
- Partials       3902     3903       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SJuliez SJuliez merged commit b8dc0e3 into MegaMek:master Nov 2, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants