MM Scenarios: Princess settings #6156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # megamek/data/scenarios/Kell Hounds/LoweringTheBoom/LoweringTheBoom.mms # megamek/src/megamek/client/ui/swing/MegaMekGUI.java # megamek/src/megamek/common/jacksonadapters/MessageDeserializer.java # megamek/src/megamek/common/scenario/ScenarioV2.java # megamek/testresources/data/scenarios/test_setups/BotvBot.mms
# Conflicts: # megamek/src/megamek/common/scenario/ScenarioV2.java
# Conflicts: # megamek/src/megamek/client/ui/swing/util/FlatLafStyleBuilder.java
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6156 +/- ##
============================================
- Coverage 29.18% 29.17% -0.02%
+ Complexity 13974 13973 -1
============================================
Files 2623 2628 +5
Lines 266441 266583 +142
Branches 47594 47615 +21
============================================
+ Hits 77774 77775 +1
- Misses 184765 184905 +140
- Partials 3902 3903 +1 ☔ View full report in Codecov by Sentry. |
HammerGS
approved these changes
Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds parsing support for bot settings in the scenario (V2) language and updates one of the new scenarios (Kell Hounds/Lowering the Boom) so that both sides can be played with the bot either fleeing or pursuing.