Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc issues #6154

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Misc issues #6154

merged 1 commit into from
Oct 30, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Oct 29, 2024

  • properly dispose the map editor boardview so it doesnt receive events later
  • in the lobby's board preview, react directly to the deployment zone checkbox and remove the "update" button
  • minor changes (removing unused code etc)

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.19%. Comparing base (c69bfa8) to head (179fdea).
Report is 49 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6154      +/-   ##
============================================
+ Coverage     29.07%   29.19%   +0.11%     
- Complexity    13972    13975       +3     
============================================
  Files          2601     2623      +22     
  Lines        267448   266397    -1051     
  Branches      47747    47583     -164     
============================================
+ Hits          77769    77776       +7     
+ Misses       185776   184716    -1060     
- Partials       3903     3905       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SJuliez SJuliez merged commit b4cdeda into MegaMek:master Oct 30, 2024
6 checks passed
@SJuliez SJuliez deleted the misc-issues branch October 30, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants