Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6063: Fix targeting choice with iNarcs #6115

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

SJuliez
Copy link
Member

@SJuliez SJuliez commented Oct 18, 2024

Prevents calling getPosition() on INarcPods; use BrushOffAttackAction
This would only become apparent when an iNarc-ed unit had the iNarc pod and another target in its own hex for a physical attack
Fixes #6063

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.07%. Comparing base (ab3b4b4) to head (dde30ed).
Report is 21 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6115      +/-   ##
============================================
- Coverage     29.07%   29.07%   -0.01%     
  Complexity    13970    13970              
============================================
  Files          2601     2601              
  Lines        267448   267456       +8     
  Branches      47758    47761       +3     
============================================
  Hits          77764    77764              
- Misses       185788   185796       +8     
  Partials       3896     3896              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HammerGS HammerGS merged commit 09b63d6 into MegaMek:master Oct 21, 2024
6 checks passed
@SJuliez SJuliez deleted the inarc-brush-off-fix branch October 30, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.50.01-SNAPSHOT] NPE on targetting hovercraft on same hex for Mech melee attack.
3 participants