Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show users without magazine about hide deleted users #777

Closed
wants to merge 2 commits into from
Closed

Show users without magazine about hide deleted users #777

wants to merge 2 commits into from

Conversation

melroy89
Copy link
Member

  • Show users on the magazine people listing page even when they do not have about or an avatar
  • Refactor method name to reflect the actual behavior
  • Also check for user is_deleted database column in queries
  • Small lint doc notice added.

@melroy89
Show users without about & avatar. Just like we have on people listin…
626fff4 
…g already. Refactor method name. Also include isDeleted check to the queries.
@melroy89
Add note to lint docs
deb5abe
@melroy89 melroy89 added documentation Improvements or additions to documentation enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end backend Backend related issues and pull requests labels May 13, 2024
@melroy89
Copy link
Member Author

Superseded by #773

@melroy89 melroy89 closed this May 13, 2024
@melroy89 melroy89 deleted the show_users_without_magazine_about_hide_deleted_users branch May 13, 2024 17:03
e-five256 added a commit that referenced this pull request May 13, 2024
@e-five256
refactor find method
80711b6 
based on #777, add filter for is deleted and rename findpeople method
@e-five256 e-five256 mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backend Backend related issues and pull requests documentation Improvements or additions to documentation enhancement New feature or request frontend Visual issues, improvements, bugs or other aspects relating mostly to the front end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@melroy89