Fixes to user filters on active user sidebar and people pages #773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
remove about requirements from magazine people front calls remove avatar requirement from magazine people front calls, kept for active user component
e-five256
changed the title
based on #777, add filter for is deleted and rename findpeople method
ghost
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ended up being a few different things. I started making some of the changes as a separate PR but since all the code and views are very similar it was a bit difficult to test separately
This makes some changes to what users can be shown as Active Users in the sidebar or Local/Federated Users on the People pages in and out of magazines
Mainly noticed that suspended users still showed up in active users on the sidebar. When I went to fix this and couldn't get any of my users to show up at all, realized it was because they didn't have About descriptions set and that was still required for the sidebar and inside magazine people pages
user.visibilitynot being filtered forvisibleonlyPeopleFrontController(/people)MagazinePeopleFrontController(/m/<mag>/people)ActiveUserComponent(sidebar)PeopleFrontControllerMagazinePeopleFrontController(/m/<mag>/people)ActiveUserComponent(sidebar)PeopleFrontControllerMagazinePeopleFrontController(/m/<mag>/people)ActiveUserComponent(sidebar), as the component is only avatars it remains required to show users thereuser.isDeletednot being filtered (From Show users without magazine about hide deleted users #777)ActiveUserComponent(sidebar)MagazinePeopleFrontController(/m/<mag>/people)findPeople()->findUsersForMagazine()(From Show users without magazine about hide deleted users #777)