Feature remote reporting #249

BentiGorlich · 2023-11-11T22:13:55Z

Add sending of a FlagMessage whenever a SubjectReportedEvent is fired and add the code that handles that message.
That leads to the propagation of reports.

This branch is based on the previous branch which fetches moderators and subscriber count from remote magazines.

Here is more testing necessary and it is not the easiest to test, especially for the edge cases (e.g.: a local magazine with a remote moderator. The remote moderator should still get the report on his instance).

Resources:

BentiGorlich · 2023-11-11T22:15:41Z

Something I noticed is not implemented yet even though I thought it was: notifications on reports. Imo you should definitely be notified via e-mail when a report occurs (should of course be able to be turned off)

BentiGorlich · 2023-11-11T22:56:15Z

ToDo List:

further testing
handle special case with the random magazine

BentiGorlich · 2023-11-30T18:20:18Z

what do you guys think about sending the report to the home instance of a user, too? If one reports a post, what should happen then?

BentiGorlich · 2023-11-30T22:59:54Z

What is working:

report posts in a magazine to lemmy or other mBin instances (tested)
report posts in the random magazine to Mastodon (tested)

What is not working:

report posts in a magazine to Mastodon (not tested, but I would be very suprised if it worked)

ghost · 2023-12-01T00:41:45Z

migrations/Version20231130203400.php

+    public function up(Schema $schema): void
+    {
+        $this->addSql('ALTER TABLE report ADD uuid VARCHAR(255) NULL');
+        $this->addSql('CREATE UNIQUE INDEX UNIQ_REPORT_UUID ON report (uuid)');


Do we want to follow the _idx naming convention that's used for indexes elsewhere? Not a big deal, just curious what your preference is.

I don't really have a preference. I just wanted it to have a readably name, but an idx in front of it wouldn't hurt :D

Actually it should be lower case as well. But more importantly. Since we are using doctrine. You need to define indexes in the entity php file.. For example see how it is done in User.php:

#[Table(name: '`user`', uniqueConstraints: [ new UniqueConstraint(name: 'user_email_idx', columns: ['email']), new UniqueConstraint(name: 'user_username_idx', columns: ['username']), ])] #[Index(columns: ['visibility'], name: 'user_visibility_idx')]

After you added a unique contain, you can use symphony doctrine CLI command to generate a migration file for you :).. If you don't do this correctly symfony migration diff will also trigger a difference between the code and the DB in the future.

I added it to doctrine via the 'unique' attribute when defining the column. I generated this fipe with the doctrine command and chanhed the index name. Thats all I did 😅

The way I did it now causes no diff. When I did it with the #[Table...] attribute I it constantly wanted to rename the index even though it had the name that I put into the migration...

migrations/Version20231130203400.php

ghost

After the most recent commit/fix for earlier issues, federated functional verification for each reporting case seems to "pass" now (albeit via manual 2-way testing with @BentiGorlich's help). And all other federated activity seems to behave normally as well, so I approve!

BentiGorlich · 2023-12-19T08:19:06Z

what do you guys think about sending the report to the home instance of a user, too? If one reports a post, what should happen then?

@asdfzdfj @e-five256 @melroy89 ?

I think I will not put it in this PR, one can always add that later

- the outbound reports should work now

- add logging - add id to Outbox/FlagMessage - make generated urls absolute

- make 'id' and make it a valid url so the signature checks don't fail

- fix using wrong indexes

- implement special case for the random magazine - add a way to access the report object. Add a UUID field in the db for that - create a factory which can be used in the new ReportController.php

- the subject could not be found previously, because the subject url was not the absolute url, so if a user reported a post to a remote magazine, that originated from their own instance it would throw errors

ghost

Re-approval after merge conflict resolution, no issues observed.

BentiGorlich requested review from melroy89, asdfzdfj, a user and e-five256 November 11, 2023 22:13

BentiGorlich self-assigned this Nov 11, 2023

BentiGorlich added enhancement New feature or request activitypub ActivityPub related issues backend Backend related issues and pull requests labels Nov 11, 2023

BentiGorlich force-pushed the feature_remote_retrieval_mod_followers branch from 4cc8b0f to ff3c263 Compare November 11, 2023 22:23

BentiGorlich force-pushed the feature_remote_reporting branch from 02ba08c to f6194b2 Compare November 11, 2023 22:33

BentiGorlich force-pushed the feature_remote_retrieval_mod_followers branch from 945959e to 70f6c11 Compare November 12, 2023 18:05

BentiGorlich force-pushed the feature_remote_reporting branch from f6194b2 to be6b547 Compare November 12, 2023 18:15

BentiGorlich force-pushed the feature_remote_retrieval_mod_followers branch 3 times, most recently from 475ed19 to 166c0b9 Compare November 23, 2023 21:29

Base automatically changed from feature_remote_retrieval_mod_followers to main November 26, 2023 13:53

BentiGorlich mentioned this pull request Nov 30, 2023

Correct Information about remote magazines #217

Closed

BentiGorlich force-pushed the feature_remote_reporting branch from be6b547 to 171d759 Compare November 30, 2023 18:16

BentiGorlich marked this pull request as ready for review November 30, 2023 23:00

BentiGorlich force-pushed the feature_remote_reporting branch from 2aac964 to 5f3e087 Compare November 30, 2023 23:00

ghost reviewed Dec 1, 2023

View reviewed changes

e-five256 reviewed Dec 1, 2023

View reviewed changes

migrations/Version20231130203400.php Outdated Show resolved Hide resolved

e-five256 mentioned this pull request Dec 1, 2023

Improve report dialog #318

Open

BentiGorlich requested review from a user and e-five256 December 18, 2023 20:19

ghost previously approved these changes Dec 19, 2023

View reviewed changes

BentiGorlich added 7 commits December 19, 2023 21:20

WIP: start federating reports

3111442

- the outbound reports should work now

Fix sending outbox FlagMessages

2aeb258

- add logging - add id to Outbox/FlagMessage - make generated urls absolute

Fix sending outbox FlagMessages

e467a04

- make 'id' and make it a valid url so the signature checks don't fail

Fix handling inbox FlagMessages

7425549

- fix using wrong indexes

Report propagation

94da5c8

- implement special case for the random magazine - add a way to access the report object. Add a UUID field in the db for that - create a factory which can be used in the new ReportController.php

Fix migration diffs, add unique index with correct name

ffee17e

Fix subjects not being found

1cefb49

- the subject could not be found previously, because the subject url was not the absolute url, so if a user reported a post to a remote magazine, that originated from their own instance it would throw errors

BentiGorlich dismissed ghost ’s stale review via 1cefb49 December 19, 2023 20:24

BentiGorlich force-pushed the feature_remote_reporting branch from 8c18978 to 1cefb49 Compare December 19, 2023 20:24

BentiGorlich and others added 3 commits December 19, 2023 21:43

fix style

7823ee5

Merge branch 'main' into feature_remote_reporting

14011af

Merge branch 'main' into feature_remote_reporting

d9cde20

ghost self-requested a review December 22, 2023 15:21

ghost approved these changes Dec 22, 2023

View reviewed changes

debounced added 11 commits December 22, 2023 19:18

Merge branch 'main' into feature_remote_reporting

d6e210a

Merge branch 'main' into feature_remote_reporting

e865c91

Merge branch 'main' into feature_remote_reporting

81769a5

Merge branch 'main' into feature_remote_reporting

9bcd6d0

Merge branch 'main' into feature_remote_reporting

b1cbc88

Merge branch 'main' into feature_remote_reporting

833efe4

Merge branch 'main' into feature_remote_reporting

438e312

Merge branch 'main' into feature_remote_reporting

ec5872e

Merge branch 'main' into feature_remote_reporting

8e9886a

Merge branch 'main' into feature_remote_reporting

266e752

Merge branch 'main' into feature_remote_reporting

9eccc77

ghost merged commit 8579724 into main Jan 4, 2024
7 checks passed

ghost deleted the feature_remote_reporting branch January 4, 2024 14:58

BentiGorlich mentioned this pull request Jun 15, 2024

Implement report notifications #783

Merged

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature remote reporting #249

Feature remote reporting #249

BentiGorlich commented Nov 11, 2023 •

edited

Loading

BentiGorlich commented Nov 11, 2023

BentiGorlich commented Nov 11, 2023 •

edited

Loading

BentiGorlich commented Nov 30, 2023 •

edited

Loading

BentiGorlich commented Nov 30, 2023 •

edited

Loading

ghost Dec 1, 2023 •

edited by ghost

Loading

BentiGorlich Dec 1, 2023

melroy89 Dec 5, 2023

BentiGorlich Dec 5, 2023

BentiGorlich Dec 18, 2023

ghost left a comment •

edited by ghost

Loading

BentiGorlich commented Dec 19, 2023

ghost left a comment

Feature remote reporting #249

Feature remote reporting #249

Conversation

BentiGorlich commented Nov 11, 2023 • edited Loading

BentiGorlich commented Nov 11, 2023

BentiGorlich commented Nov 11, 2023 • edited Loading

BentiGorlich commented Nov 30, 2023 • edited Loading

BentiGorlich commented Nov 30, 2023 • edited Loading

ghost Dec 1, 2023 • edited by ghost Loading

Choose a reason for hiding this comment

BentiGorlich Dec 1, 2023

Choose a reason for hiding this comment

melroy89 Dec 5, 2023

Choose a reason for hiding this comment

BentiGorlich Dec 5, 2023

Choose a reason for hiding this comment

BentiGorlich Dec 18, 2023

Choose a reason for hiding this comment

ghost left a comment • edited by ghost Loading

Choose a reason for hiding this comment

BentiGorlich commented Dec 19, 2023

ghost left a comment

Choose a reason for hiding this comment

BentiGorlich commented Nov 11, 2023 •

edited

Loading

BentiGorlich commented Nov 11, 2023 •

edited

Loading

BentiGorlich commented Nov 30, 2023 •

edited

Loading

BentiGorlich commented Nov 30, 2023 •

edited

Loading

ghost Dec 1, 2023 •

edited by ghost

Loading

ghost left a comment •

edited by ghost

Loading