Implement report notifications #783

BentiGorlich · 2024-05-15T13:41:32Z

notifications when
- a report is created -> admins, global mods, magazine mods
- a report is accepted -> ~~reporting user and~~ reported user
- ~~a report is rejected -> reporting user~~
notifications are marked as read when a user can see them:
- admin report panel: all notifications for the current user with attached reports
- magazine report panel: all notifications for the current user with attached reports for something in the magazine
- personal report panel: all notifications with attached reports reported by the current user
change the personal report panel to include only the reports reported by the current user

Closes #255

- notifications when - a report is created -> admins, global mods, magazine mods - a report is accepted -> reporting user and reported user - a report is rejected -> reporting user - notifications are marked as read when a user can see them: - admin report panel: all notifications for the current user with attached reports - magazine report panel: all notifications for the current user with attached reports for something in the magazine - personal report panel: all notifications with attached reports reported by the current user - change the personal report panel to include only the reports reported by the current user

e-five256 · 2024-05-16T01:17:43Z

notification when

a report is rejected -> reporting user

I'll have to check this out but I can see it being a bit confusing. One of the issues it feels like we have is that people report remote content, for things like rules of the remote magazine, where really the deciding factor is the remote magazine moderators, and not the site admin. I'm not sure if it's common to reject the report in this case, or just ignore it, feels like there isn't really a good solution and then even if the content is moderated remotely, it never makes it back to Mbin, making things even more confusing

BentiGorlich · 2024-05-16T07:14:28Z

We could add a check for open reports when we receive a delete activity and mark the report as accepted. I don't know whether that solves the problem.
However from moderating my mastodon server I gotta say that I deal with reports directly even if it is a remote userthat is reported, because youd server might just have different rules in general that apply to everything than the server of the remote magazine...

jwr1 · 2024-05-16T15:50:26Z

notifications when
a report is accepted -> reporting user and reported user
a report is rejected -> reporting user

I can see why the reported user should know if their content is removed (so they can discuss it with the mod/admin), but why should the reporting user be notified if it's accepted or not? Let's say I see a bunch of spam posts and I report all of them, I can't think of a case where I would want to be notified of whether the posts were removed or not. Reporting is supposed to let the mod/admin know of possibly problematic content, and then they can deal with it as they see fit; the reporting user shouldn't have to think/worry about the content once they have reported it.

jwr1 · 2024-05-16T16:00:15Z

Also, it would be great if this works for the API as well. I'm assuming the new notification types show up in the API (report_created, report_approved, and report_rejected), but will the new report_id field be added?

BentiGorlich · 2024-05-16T16:16:01Z

the reporting user shouldn't have to think/worry about the content once they have reported it.

That is true, but I thought that I would want to know if it helps to report stuff... It shows that the admins/mods care about reports...

Also, it would be great if this works for the API as well. I'm assuming the new notification types show up in the API (report_created, report_approved, and report_rejected), but will the new report_id field be added?

Tbh I always forget the API, so yes that will definitely be added 😅

ryanjsims · 2024-06-06T21:54:35Z

src/Controller/Api/Notification/NotificationBaseApi.php

+                /** @var ReportCreatedNotification $n */
+                $n = $dto;
+                $toReturn['reportId'] = $n->report->getId();
+                break;


The notification structure has the actual subject of the notification detailed - using the report id instead breaks this convention, and would also make it impossible for regular users to have any information about the report contained in this notification displayed by the app using the API, since retrieving reports is a moderator and admin only API endpoint.
This solution would not be sufficient if we wanted to display the reason a user's post was deleted in the notification using the API, for example

What I would recommend would be to follow the convention of the other notifications and embed a subset of the report in the notification, at least the reason, magazine, type, and subjectId of the report
subjectId would be the post/comment/entry that was reported and removed

I'll check that

Ok, here are my thoughts:

ReportCreatedNotification: only admins and mods can get this, so imo its fine to only send the id of the report, but of course a dto of the report could be added for this.

ReportRejectedNotification: a user should be able to see their own reports, but if not maybe add the subject of the report here, as there is no reason supplied for rejecting a report.

ReportApprovedNotification: since this is going to the author of the reported content, the subject that was reported should be enough.

Would you be fine with that?

The reason I do not just want to add a report dto to all of them is simple: you should never be informed who is reporting your content for which reason, unless the report is accepted, but even then the reason the reporting user supplied is not necessarily the one the mod removed your content for. Since we do not have a "moderators_reason" field (or something similar) it would not make much sense to just relay that information to the reported user

jwr1 · 2024-06-13T14:36:56Z

Also, what about the case where a reported post might be breaking magazine rules but not instance rules? If an admin rejects a report because they want the magazine moderator to deal with it instead (at their own discretion), won't it still notify the reporting user? Or are we supposed to just leave it in pending?

BentiGorlich · 2024-06-14T11:33:31Z

Also, what about the case where a reported post might be breaking magazine rules but not instance rules? If an admin rejects a report because they want the magazine moderator to deal with it instead (at their own discretion), won't it still notify the reporting user? Or are we supposed to just leave it in pending?

You're supposed to just leave it pending. Since there is just one report for everyone and no distinction between moderator and admin level...

jwr1 · 2024-06-14T19:09:35Z

You're supposed to just leave it pending. Since there is just one report for everyone and no distinction between moderator and admin level...

And then the moderator never does anything with the report, so it just sits in pending for all eternity... (Meaning I have to look at it every single time I check the reports page.) Maybe we need to add a "hide" button to reports, to hide them from pending but not actually approve or reject them.

jwr1 · 2024-06-14T19:21:17Z

Also, just wondering, do reports even federate to and from Lemmy correctly?

BentiGorlich · 2024-06-15T15:10:59Z

And then the moderator never does anything with the report, so it just sits in pending for all eternity... (Meaning I have to look at it every single time I check the reports page.) Maybe we need to add a "hide" button to reports, to hide them from pending but not actually approve or reject them.

Well maybe, but way out of scope of this PR...

Also, just wondering, do reports even federate to and from Lemmy correctly?

Yes, they should. Report federation was introduced in #249

ghost · 2024-07-14T15:14:42Z

so.... what is the group consensus on this @BentiGorlich @e-five256 @jwr1 @ryanjsims @melroy89? PR has been open since May...

jwr1 · 2024-07-14T16:48:32Z

Honestly, I'm still not sold on the reporting user being notified (when report is approved or declined). I do think the reported content's user should be notified if their post/comment was removed (in case they want to appeal), and it makes sense, for obvious reasons, why admins, global mods, and mag mods should be notified on report creation.

BentiGorlich · 2024-07-15T07:29:09Z

Yeah I have to get back on this. I am fine with what @jwr1 said. Have to change the API objects as well

- do not notify anyone on a rejected report - only notify the author of the removed content when a report is accepted - Adjust the API endpoint to have the reported subject as the `subject` and the `reason` if it is a `ReportCreatedNotification`

BentiGorlich · 2024-07-23T09:33:25Z

Yeah that makes sense. I think I will just not display the link when the user does not have permissions to view it

ghost

i've already used this quite a bit, very useful for prompt mod action.

BentiGorlich added enhancement New feature or request backend Backend related issues and pull requests labels May 15, 2024

BentiGorlich self-assigned this May 15, 2024

BentiGorlich added 2 commits May 16, 2024 16:16

Merge branch 'main' into new/report-notifications

0457c5b

Add the new notifications to the API

7e1f228

BentiGorlich added this to the v1.6.1 milestone May 31, 2024

BentiGorlich added 2 commits June 3, 2024 10:08

Merge branch 'main' into new/report-notifications

8fb4ef6

Merge branch 'main' into new/report-notifications

22e72fa

ryanjsims reviewed Jun 6, 2024

View reviewed changes

Merge branch 'main' into new/report-notifications

bc5e8b1

BentiGorlich and others added 3 commits June 16, 2024 00:21

Merge branch 'main' into new/report-notifications

bb160ae

Merge branch 'main' into new/report-notifications

98c61a5

Merge branch 'main' into new/report-notifications

6d4a55b

melroy89 requested a review from ryanjsims July 9, 2024 18:10

Merge branch 'main' into new/report-notifications

097d455

Merge branch 'main' into new/report-notifications

d343d78

BentiGorlich and others added 4 commits July 15, 2024 18:56

Adjust recipients and API objects

b03874a

- do not notify anyone on a rejected report - only notify the author of the removed content when a report is accepted - Adjust the API endpoint to have the reported subject as the `subject` and the `reason` if it is a `ReportCreatedNotification`

Merge branch 'main' into new/report-notifications

b5984f6

Merge branch 'main' into new/report-notifications

986ebf8

Merge branch 'main' into new/report-notifications

d660daa

This comment was marked as resolved.

Sign in to view

Merge branch 'main' into new/report-notifications

1d9a85e

debounced and others added 3 commits July 24, 2024 10:32

Merge branch 'main' into new/report-notifications

a794a4c

Merge branch 'main' into new/report-notifications

dbc8528

Only show "open report" for people with permission to view it

8900450

ghost requested review from a user and removed request for ryanjsims July 25, 2024 13:37

ghost approved these changes Jul 25, 2024

View reviewed changes

Merge branch 'main' into new/report-notifications

5ec8723

BentiGorlich merged commit 434a4c8 into main Jul 25, 2024
7 checks passed

BentiGorlich deleted the new/report-notifications branch July 25, 2024 14:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement report notifications #783

Implement report notifications #783

BentiGorlich commented May 15, 2024 •

edited

Loading

e-five256 commented May 16, 2024

BentiGorlich commented May 16, 2024

jwr1 commented May 16, 2024 •

edited

Loading

jwr1 commented May 16, 2024

BentiGorlich commented May 16, 2024

ryanjsims Jun 6, 2024

ryanjsims Jun 7, 2024

BentiGorlich Jun 14, 2024

BentiGorlich Jun 15, 2024

jwr1 commented Jun 13, 2024

BentiGorlich commented Jun 14, 2024

jwr1 commented Jun 14, 2024 •

edited

Loading

jwr1 commented Jun 14, 2024

BentiGorlich commented Jun 15, 2024

ghost commented Jul 14, 2024

jwr1 commented Jul 14, 2024 •

edited

Loading

BentiGorlich commented Jul 15, 2024

This comment was marked as resolved.

BentiGorlich commented Jul 23, 2024

ghost left a comment

Implement report notifications #783

Implement report notifications #783

Conversation

BentiGorlich commented May 15, 2024 • edited Loading

e-five256 commented May 16, 2024

BentiGorlich commented May 16, 2024

jwr1 commented May 16, 2024 • edited Loading

jwr1 commented May 16, 2024

BentiGorlich commented May 16, 2024

ryanjsims Jun 6, 2024

Choose a reason for hiding this comment

ryanjsims Jun 7, 2024

Choose a reason for hiding this comment

BentiGorlich Jun 14, 2024

Choose a reason for hiding this comment

BentiGorlich Jun 15, 2024

Choose a reason for hiding this comment

jwr1 commented Jun 13, 2024

BentiGorlich commented Jun 14, 2024

jwr1 commented Jun 14, 2024 • edited Loading

jwr1 commented Jun 14, 2024

BentiGorlich commented Jun 15, 2024

ghost commented Jul 14, 2024

jwr1 commented Jul 14, 2024 • edited Loading

BentiGorlich commented Jul 15, 2024

This comment was marked as resolved.

BentiGorlich commented Jul 23, 2024

ghost left a comment

Choose a reason for hiding this comment

BentiGorlich commented May 15, 2024 •

edited

Loading

jwr1 commented May 16, 2024 •

edited

Loading

jwr1 commented Jun 14, 2024 •

edited

Loading

jwr1 commented Jul 14, 2024 •

edited

Loading