Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 3.6] Move scripts/code_style.py to the framework #9837

Merged
merged 4 commits into from
Dec 18, 2024
Merged

[Backport 3.6] Move scripts/code_style.py to the framework #9837

merged 4 commits into from
Dec 18, 2024

Conversation

eleuzi01
Copy link
Contributor

Description

Resolves Mbed-TLS/mbedtls-framework#70

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@eleuzi01 eleuzi01 added enhancement needs-ci Needs to pass CI tests size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Dec 10, 2024
@eleuzi01 eleuzi01 mentioned this pull request Dec 10, 2024
Merged
6 tasks
@eleuzi01 eleuzi01 added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Dec 11, 2024
@valeriosetti valeriosetti mentioned this pull request Dec 13, 2024
Merged
@valeriosetti valeriosetti self-requested a review December 13, 2024 13:56
valeriosetti
valeriosetti previously approved these changes Dec 13, 2024
View reviewed changes
@eleuzi01
Move files out of Mbed TLS
711abe3 
Signed-off-by: Elena Uziunaite <[email protected]>
@eleuzi01
Adjust paths
993df66 
Signed-off-by: Elena Uziunaite <[email protected]>
@eleuzi01
Update submodule
a3c601e 
Signed-off-by: Elena Uziunaite <[email protected]>
@ronald-cron-arm ronald-cron-arm removed the needs-reviewer This PR needs someone to pick it up for review label Dec 18, 2024
valeriosetti
valeriosetti previously approved these changes Dec 18, 2024
View reviewed changes
minosgalanakis
minosgalanakis previously approved these changes Dec 18, 2024
View reviewed changes
Copy link
Contributor

@minosgalanakis minosgalanakis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eleuzi01
Update submodule with the merge
fc513fe 
Signed-off-by: Elena Uziunaite <[email protected]>
@eleuzi01 eleuzi01 dismissed stale reviews from minosgalanakis and valeriosetti via fc513fe December 18, 2024 14:32
@ronald-cron-arm ronald-cron-arm added this pull request to the merge queue Dec 18, 2024
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit cee38eb Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valeriosetti valeriosetti valeriosetti approved these changes

@minosgalanakis minosgalanakis minosgalanakis approved these changes

Assignees
No one assigned
Labels
enhancement needs-review Every commit must be reviewed by at least two team members, priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Roadmap pull requests (new board)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eleuzi01 @minosgalanakis @valeriosetti @ronald-cron-arm