Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps to v0.9.22 #571

Merged
merged 43 commits into from
Jul 13, 2022
Merged

Bump deps to v0.9.22 #571

merged 43 commits into from
Jul 13, 2022

Conversation

Dengjianping
Copy link
Contributor

@Dengjianping Dengjianping commented Jun 4, 2022

Signed-off-by: Dengjianping [email protected]

Description

closes: #538
closes: #379
closes: #390

Substrate:

v0.9.18 -> v0.9.19

v0.9.19 -> v0.9.20

v0.9.20 -> v0.9.21:

  • None

v0.9.21 -> v0.9.22

Polkadot:

v0.9.18 -> v0.9.19

v0.9.19 -> v0.9.20

v0.9.20 -> v0.9.21

v0.9.21 -> v0.9.22

Cumuls:

v0.9.18 -> v0.9.19

v0.9.19 -> v0.9.20

  • None. Only some PRs for bumping deps.

v0.9.20 -> v0.9.21

  • None. This branch doesn't exsit. Because v0.9.21 is a emergency release in polkadot.

v0.9.21 -> v0.9.22

Manta

./manta benchmark -h

=>

SUBCOMMANDS:
    block       Benchmark the execution time of historic blocks
    help        Print this message or the help of the given subcommand(s)
    overhead    Benchmark the execution overhead per-block and per-extrinsic
    pallet      Benchmark the extrinsic weight of FRAME Pallets
    storage     Benchmark the storage speed of a chain snapshot

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests.
  • Updated relevant documentation in the code.
  • Added one line describing your change in <branch>/CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer.
  • If runtime changes, need to update the version numbers properly:
    • authoring_version: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.
    • spec_version: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.
    • impl_version: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.
    • transaction_version: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run the metadata_diff.yml workflow for help. If this number is updated, then the spec_version must also be updated
  • Verify benchmarks & weights have been updated for any modified runtime logics
  • If importing a new pallet, choose a proper module index for it, and allow it in BaseFilter. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.
  • If needed, update our Javascript/Typescript APIs. These APIs are officially used by exchanges or community developers.
  • If modifying existing runtime storage items, make sure to implement storage migrations for the runtime and test them with try-runtime. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of #[pallet::storage] items to check for any.

Signed-off-by: Dengjianping <[email protected]>
@Dengjianping Dengjianping added A-manta Area: Issues and PRs related to the Manta Runtime A-calamari Area: Issues and PRs related to the Calamari Runtime A-runtime Area: Issues and PRs related to Runtimes P-high Priority: High A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-polkadot-dependency Area: Issues and PRs related to Polkadot as a Dependency labels Jun 4, 2022
@Dengjianping Dengjianping added this to the v3.2.0 milestone Jun 4, 2022
@Dengjianping Dengjianping self-assigned this Jun 4, 2022
node/src/cli.rs Outdated Show resolved Hide resolved
node/src/service.rs Outdated Show resolved Hide resolved
@stechu stechu modified the milestones: v3.2.0, v3.2.1 Jun 7, 2022
@Dengjianping
Copy link
Contributor Author

In this PR, we must rewrite rpc part for manta-pay with jsonrpsee. And there's a comment we should be careful
#529 (comment)

@Dengjianping Dengjianping mentioned this pull request Jun 8, 2022
13 tasks
Signed-off-by: Dengjianping <[email protected]>
Garandor
Garandor previously approved these changes Jul 12, 2022
@Garandor
Copy link
Contributor

Garandor commented Jul 13, 2022

Signed-off-by: Adam Reif <[email protected]>
Copy link
Contributor

@Garandor Garandor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ghzlatarev ghzlatarev merged commit c620999 into manta Jul 13, 2022
@ghzlatarev ghzlatarev deleted the jamie/v0.9.22 branch July 13, 2022 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-calamari Area: Issues and PRs related to the Calamari Runtime A-dolphin Area: Issues and PRs related to the Dolphin Runtime A-manta Area: Issues and PRs related to the Manta Runtime A-polkadot-dependency Area: Issues and PRs related to Polkadot as a Dependency A-runtime Area: Issues and PRs related to Runtimes P-high Priority: High
Projects
None yet
5 participants