-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump deps to v0.9.22 #571
Merged
Merged
Bump deps to v0.9.22 #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dengjianping <[email protected]>
Dengjianping
added
A-manta
Area: Issues and PRs related to the Manta Runtime
A-calamari
Area: Issues and PRs related to the Calamari Runtime
A-runtime
Area: Issues and PRs related to Runtimes
P-high
Priority: High
A-dolphin
Area: Issues and PRs related to the Dolphin Runtime
A-polkadot-dependency
Area: Issues and PRs related to Polkadot as a Dependency
labels
Jun 4, 2022
This was referenced Jun 6, 2022
ghzlatarev
reviewed
Jun 6, 2022
ghzlatarev
reviewed
Jun 6, 2022
ghzlatarev
reviewed
Jun 6, 2022
ghzlatarev
reviewed
Jun 6, 2022
ghzlatarev
reviewed
Jun 6, 2022
ghzlatarev
reviewed
Jun 6, 2022
In this PR, we must rewrite rpc part for manta-pay with jsonrpsee. And there's a comment we should be careful |
13 tasks
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Dengjianping <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Garandor
reviewed
Jul 12, 2022
Garandor
previously approved these changes
Jul 12, 2022
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Signed-off-by: Adam Reif <[email protected]>
Pls resolve this comment the PR here: |
Signed-off-by: Adam Reif <[email protected]>
Garandor
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ghzlatarev
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-calamari
Area: Issues and PRs related to the Calamari Runtime
A-dolphin
Area: Issues and PRs related to the Dolphin Runtime
A-manta
Area: Issues and PRs related to the Manta Runtime
A-polkadot-dependency
Area: Issues and PRs related to Polkadot as a Dependency
A-runtime
Area: Issues and PRs related to Runtimes
P-high
Priority: High
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dengjianping [email protected]
Description
closes: #538
closes: #379
closes: #390
Substrate:
v0.9.18 -> v0.9.19
benchmark-storage
flags: Additionalbenchmark-storage
flags paritytech/substrate#11004dev_getblockstats
rpc: Adddev_getBlockStats
RPC paritytech/substrate#10939benchmark-block
command: Addbenchmark-block
command paritytech/substrate#11091wasm
: Change default execution strategies toWasm
paritytech/substrate#11170benchmark
: Sub-commands forbenchmark
paritytech/substrate#11164seal_delegate_call
: contracts: Stabilizeseal_delegate_call
paritytech/substrate#11037seal_code_hash
andseal_own_code_hash
: contracts: addseal_code_hash
andseal_own_code_hash
to API paritytech/substrate#10933weighttofeepolynomial
s to `pallet_transaction_payment...: ApplyWeightToFeePolynomial
s topallet_transaction_payment
's length fee paritytech/substrate#10785v0.9.19 -> v0.9.20
benchmark machine
: Addbenchmark machine
paritytech/substrate#11198v0.9.20 -> v0.9.21:
v0.9.21 -> v0.9.22
chain-info
subcommand: Addchain-info
Subcommand paritytech/substrate#11250--unsafe-pruning
cli-argument (step 1): Remove the--unsafe-pruning
CLI-argument (step 1) paritytech/substrate#10995frame_support::crypto::ecdsa::public.to_eth_address()
: Addframe_support::crypto::ecdsa::Public.to_eth_address()
(k256
-based) and use it in pallets paritytech/substrate#11087Polkadot:
v0.9.18 -> v0.9.19
v0.9.19 -> v0.9.20
benchmark machine
command: Co #11198: Exposebenchmark machine
command paritytech/polkadot#5326v0.9.20 -> v0.9.21
dispute-coordinator
message burstiness handling paritytech/polkadot#5471v0.9.21 -> v0.9.22
Cumuls:
v0.9.18 -> v0.9.19
benchmark
: Co #11164: Sub-commands forbenchmark
paritytech/cumulus#1156benchmark
: Co #11164: Sub-commands forbenchmark
paritytech/cumulus#1156benchmark machine
command: Co #11198: Exposebenchmark machine
command paritytech/cumulus#1172ParachainHost
in Polkadot: Handle relocation ofParachainHost
in Polkadot paritytech/cumulus#1108v0.9.19 -> v0.9.20
v0.9.20 -> v0.9.21
v0.9.21 -> v0.9.22
Manta
use cumulus_primitives_core::relay_chain::v1
=>use cumulus_primitives_core::{relay_chain::v2
See both PRs: [Companion for primitives consolidation into v2](Companion for primitives consolidation into v2 paritytech/cumulus#1071) and [Finish migration to v2 primitives](Finish migration to v2 primitives paritytech/polkadot#5037)
construct_benchmark_partials
which is used for benchmark:See this PR: Sub-commands for
benchmark
#![allow(clippy::unnecessary_cast)]
josnrpsee
.mantaPay_pull_ledger_diff
from manta-pay asblocking
.https://github.com/Manta-Network/Manta/pull/571/files#diff-ada1b74d9d0e41a7bc44d9d3ef17a29cb751ef83d034424adcb6c3a671f6c1a5
match_type
withmatch_types
, the previous one is going to be deprecated.error
inDispatchError
become fromu32
to[u8; 4]
. Be careful with this change, it will reflect on front-end.See this PR: Allow pallet error enum variants to contain fields paritytech/substrate#10242
https://github.com/Manta-Network/Manta/pull/571/files#diff-3287a4ee060b1070a8e6559a094b4890a596a1b281effef54cafe59da20edf49R60
LengthToFee
topallet_transaction_payment
.See this PR: Apply
WeightToFeePolynomial
s topallet_transaction_payment
's length fee paritytech/substrate#10785Note: I suppose
transaction_version
will be bumped.polkadot_runtime_common
.benchmark
:=>
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
<branch>/CHANGELOG.md
Files changed
in the Github PR explorer.authoring_version
: The version of the authorship interface. An authoring node will not attempt to author blocks unless this is equal to its native runtime.spec_version
: The version of the runtime specification. A full node will not attempt to use its native runtime in substitute for the on-chain Wasm runtime unless all of spec_name, spec_version, and authoring_version are the same between Wasm and native.impl_version
: The version of the implementation of the specification. Nodes are free to ignore this; it serves only as an indication that the code is different; as long as the other two versions are the same then while the actual code may be different, it is nonetheless required to do the same thing. Non-consensus-breaking optimizations are about the only changes that could be made which would result in only the impl_version changing.transaction_version
: The version of the extrinsics interface. This number must be updated in the following circumstances: extrinsic parameters (number, order, or types) have been changed; extrinsics or pallets have been removed; or the pallet order in the construct_runtime! macro or extrinsic order in a pallet has been changed. You can run themetadata_diff.yml
workflow for help. If this number is updated, then thespec_version
must also be updatedBaseFilter
. Ensure every extrinsic works from front-end. If there's corresponding tool, ensure both work for each other.try-runtime
. This includes migrations inherited from upstream changes, and you can search the diffs for modifications of#[pallet::storage]
items to check for any.