Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI job is failing to detect formatting issues reliably #697

Closed
Garandor opened this issue Jul 19, 2022 · 1 comment
Closed

CI job is failing to detect formatting issues reliably #697

Garandor opened this issue Jul 19, 2022 · 1 comment
Labels
A-ci Area: Continuous Integration
Milestone

Comments

@Garandor
Copy link
Contributor

@Garandor I don't think there's formatting issue, because all CI jobs have passed. And I did taplo fmt/lint locally, every thing looks fine.

The old weights were checked in and all jobs were passing then too.
Both can't be right.

Sounds to me like the CI job is failing to detect formatting issues reliably after all

In order to avoid blocking this release on formatting, let's create a followup

Originally posted by @Garandor in #627 (comment)

@Garandor Garandor added the A-ci Area: Continuous Integration label Jul 19, 2022
@Garandor Garandor added this to the v3.4.0 milestone Jul 19, 2022
@Garandor
Copy link
Contributor Author

Resolved in discussion as

Manual reformat introduced in #571 which isnt caught by CI because weight files use rustfmt_skip.
Simply needs more manual scrutiny

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ci Area: Continuous Integration
Projects
None yet
Development

No branches or pull requests

1 participant