We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@Garandor I don't think there's formatting issue, because all CI jobs have passed. And I did taplo fmt/lint locally, every thing looks fine.
taplo fmt/lint
The old weights were checked in and all jobs were passing then too. Both can't be right.
Sounds to me like the CI job is failing to detect formatting issues reliably after all
In order to avoid blocking this release on formatting, let's create a followup
Originally posted by @Garandor in #627 (comment)
The text was updated successfully, but these errors were encountered:
Resolved in discussion as
Manual reformat introduced in #571 which isnt caught by CI because weight files use rustfmt_skip. Simply needs more manual scrutiny
rustfmt_skip
Sorry, something went wrong.
No branches or pull requests
The old weights were checked in and all jobs were passing then too.
Both can't be right.
Sounds to me like the CI job is failing to detect formatting issues reliably after all
In order to avoid blocking this release on formatting, let's create a followup
Originally posted by @Garandor in #627 (comment)
The text was updated successfully, but these errors were encountered: