Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip trailing .$ from Credentials #49

Merged
merged 1 commit into from
Sep 25, 2023

Conversation

agrare
Copy link
Member

@agrare agrare commented Sep 21, 2023

When transforming a payload_template style hash we have to strip off the
trailing .$ after interpolating the value.

When transforming a payload_template style hash we have to strip off the
trailing .$ after interpolating the value.
@agrare agrare added the bug Something isn't working label Sep 21, 2023
@miq-bot
Copy link
Member

miq-bot commented Sep 21, 2023

Checked commit agrare@2ffd0f3 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. 🍪

@kbrock kbrock self-assigned this Sep 25, 2023
@kbrock kbrock merged commit 209f637 into ManageIQ:master Sep 25, 2023
@agrare agrare deleted the strip_dot_dollar_from_credentials branch September 25, 2023 18:29
@Fryguy
Copy link
Member

Fryguy commented Sep 27, 2023

Backported to quinteros in commit 18704a8.

commit 18704a810ab0b18089afcdf06dbd9c7f8e271e30
Author: Keenan Brock <[email protected]>
Date:   Mon Sep 25 14:28:54 2023 -0400

    Merge pull request #49 from agrare/strip_dot_dollar_from_credentials
    
    Strip trailing .$ from Credentials
    
    (cherry picked from commit 209f637d8a9bc164c1b0018da9bd7178b8a4589a)

Fryguy pushed a commit that referenced this pull request Sep 27, 2023
Strip trailing .$ from Credentials

(cherry picked from commit 209f637)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quinteros/backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants