Run workflows asyncrhonously on MiqAutomationWorker #50
Conversation
app/models/manageiq/providers/workflows/automation_manager/workflow_instance.rb
Outdated
Show resolved
Hide resolved
| wf.step | ||
| wf.run_nonblock |
| @@ -87,6 +89,6 @@ def run(args = {}) | |||
| object.after_ae_delivery(ae_result) | |||
| end | |||
|
|
|||
| run_queue(:zone => zone, :role => role, :object => object) unless wf.end? | |||
| run_queue(:zone => zone, :role => role, :object => object, :deliver_on => 1.minute.from_now.utc) unless wf.end? | |||
There was a problem hiding this comment.
think I want to expose wf.waiting
There was a problem hiding this comment.
Yeah I was hoping to contain that knowledge inside the .wait method
spec/models/manageiq/providers/workflows/automation_manager/workflow_instance_spec.rb
Outdated
Show resolved
Hide resolved
agrare
force-pushed
the
run_workflows_on_miq_automation_worker
branch
2 times, most recently
from
8c502d1 to
0589b64
Compare
Rather than running each step in a single queue message synchronously, execute WorkflowInstances asynchronously and requeue once the workflow would block.
agrare
force-pushed
the
run_workflows_on_miq_automation_worker
branch
from
0589b64 to
98832ba
Compare
agrare
changed the title
|
Checked commits agrare/manageiq-providers-workflows@98832ba~...2d1adb9 with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
| @@ -87,6 +90,6 @@ def run(args = {}) | |||
| object.after_ae_delivery(ae_result) | |||
| end | |||
|
|
|||
| run_queue(:zone => zone, :role => role, :object => object) unless wf.end? | |||
| run_queue(:zone => zone, :role => role, :object => object, :deliver_on => 10.seconds.from_now.utc, :server_guid => MiqServer.my_server.guid) unless wf.end? | |||
There was a problem hiding this comment.
@agrare Is this what you mentioned to me?
So my question here is why we need the pinning and deliver time at all?
There was a problem hiding this comment.
Because this re-queue while the docker/podman/k8s task is still running so we don't want it to spin (hence deliver on) and we need to run it on the same server so podman inspect will be able to see the running container.
There was a problem hiding this comment.
ohhh I see - ok, this is what I wasn't understanding in our discussion yesterday because I thought it worked differently.
|
Backported to |
…rker Run workflows asyncrhonously on MiqAutomationWorker (cherry picked from commit be6f4d1)
Depends on: