-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump gotenberg from 8.5.1
to 8.7.0
& add HTTPS (TLS) support
#35
Conversation
8.5.1
to 8.6.0
& add HTTPS support8.5.1
to 8.6.0
& add HTTPS (TLS) support
Hey, I was going to add this. I want to mimic what other charts do. Usually in this situation I allow referencing a secret with the keys that is set outside the normal helm deployment, but I'll check how this is usually handled in similar charts. I rebased and added attribution for now. |
I think most would just use a volume with the TLS files in it and attach use the |
@MaikuMori If you tell me how exactly you want to implement TLS support I could improve or rework this PR myself if you want. |
Hi, sorry, I've been slacking. Basically, the 2 features I'd like are:
Regarding volumes:
This way, all cases are Secret based:
What do you think? I could try to add these changes tomorrow. |
8.5.1
to 8.6.0
& add HTTPS (TLS) support8.5.1
to 8.7.0
& add HTTPS (TLS) support
It was easier than I expected. I think there is no disadvantage of not doing it via manual volume mounts. @jonasgeiler Let me know if there are issues doing it this way in your specific workflow. Personally, I think this is more idiomatic and simpler. Also, this should support cert-manager certificates. It already supported TLS via ingress annotations previously. |
@MaikuMori sorry for not replying earlier but yeah sounds good! Thanks! I'll try it out. |
This PR bumps the
gotenberg
version from8.5.1
to8.6.0
, which adds HTTPS (TLS) support so I added the new flags to the helm chart.https://github.com/gotenberg/gotenberg/releases/tag/v8.6.0
Tasks:
Chart.yaml
CHANGELOG.md
helm-docs