Skip to content

Commit

Permalink
Merge pull request #35 from jonasgeiler/feat/tls-flags
Browse files Browse the repository at this point in the history
Bump gotenberg from `8.5.1` to `8.7.0` & add HTTPS (TLS) support
  • Loading branch information
MaikuMori authored Jun 21, 2024
2 parents bad180b + fd15a6b commit 2854221
Show file tree
Hide file tree
Showing 5 changed files with 30 additions and 3 deletions.
8 changes: 8 additions & 0 deletions charts/gotenberg/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## 1.5.0

- Bump `gotenberg` version `8.5.1` -> `8.7.0`.
- Add support for the following flags (Thanks to Jonas Geiler | [@jonasgeiler](https://github.com/jonasgeiler)):

- `--api-tls-cert-file`
- `--api-tls-key-file`

## 1.4.0

- Add ability to create and configure `PodDisruptionBudget` (Thanks to Aurel Canciu | [@relu](https://github.com/relu))
Expand Down
4 changes: 2 additions & 2 deletions charts/gotenberg/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,13 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: "1.4.0"
version: "1.5.0"

# This is the version number of the application being deployed. This version number should be
# incremented each time you make changes to the application. Versions are not expected to
# follow Semantic Versioning. They should reflect the version the application is using.
# It is recommended to use it with quotes.
appVersion: "8.5.1"
appVersion: "8.7.0"

keywords:
- gotenberg
Expand Down
3 changes: 2 additions & 1 deletion charts/gotenberg/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Gotenberg

[![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/gotenberg)](https://artifacthub.io/packages/helm/maikumori/gotenberg)
![Version: 1.4.0](https://img.shields.io/badge/Version-1.4.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 8.5.1](https://img.shields.io/badge/AppVersion-8.5.1-informational?style=flat-square)
![Version: 1.5.0](https://img.shields.io/badge/Version-1.5.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 8.7.0](https://img.shields.io/badge/AppVersion-8.7.0-informational?style=flat-square)

This is a HELM chart for Gotenberg.

Expand Down Expand Up @@ -56,6 +56,7 @@ helm upgrade my-release maikumori/gotenberg --install
| api.port | int | `3000` | Set the port on which the API should listen (default 3000) |
| api.rootPath | string | `""` | Set the root path of the API - for service discovery via URL paths (default "/") |
| api.timeout | string | `""` | Set the time limit for requests (default 30s) |
| api.tlsSecretName | string | `""` | Enables TLS on the API server: K8S TLS secret name containing the TLS certificate and key (tls.crt, tls.key) |
| api.traceHeader | string | `""` | Set the header name to use for identifying requests (default "Gotenberg-Trace") |
| autoscaling.enabled | bool | `false` | |
| autoscaling.maxReplicas | int | `100` | |
Expand Down
16 changes: 16 additions & 0 deletions charts/gotenberg/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ spec:
args:
- gotenberg
- --api-port={{ .Values.api.port }}
{{- if .Values.api.tlsSecretName }}
- --api-tls-cert-file=/tls/tls.crt
{{- end }}
{{- if .Values.api.tlsSecretName }}
- --api-tls-key-file=/tls/tls.key
{{- end }}
{{- if .Values.api.timeout }}
- --api-timeout={{ .Values.api.timeout }}
{{- end }}
Expand Down Expand Up @@ -212,6 +218,11 @@ spec:
{{- toYaml .Values.resources | nindent 12 }}
volumeMounts:
{{- toYaml .Values.volumeMounts | nindent 12 }}
{{- if .Values.api.tlsSecretName }}
- name: tls
mountPath: /tls
readOnly: true
{{- end }}
terminationGracePeriodSeconds: {{ .Values.gotenberg.gracefulShutdownDurationSec }}
{{- with .Values.nodeSelector }}
nodeSelector:
Expand All @@ -232,4 +243,9 @@ spec:
{{- with .Values.volumes }}
volumes:
{{- toYaml . | nindent 8 }}
{{- if .Values.api.tlsSecretName }}
- name: tls
secret:
secretName: {{ .Values.api.tlsSecretName }}
{{- end }}
{{- end }}
2 changes: 2 additions & 0 deletions charts/gotenberg/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,8 @@ ingress:
api:
# -- Set the port on which the API should listen (default 3000)
port: 3000
# -- Enables TLS on the API server: K8S TLS secret name containing the TLS certificate and key (tls.crt, tls.key)
tlsSecretName: ""
# -- Set the time limit for requests (default 30s)
timeout: ""
# -- Set the root path of the API - for service discovery via URL paths (default "/")
Expand Down

0 comments on commit 2854221

Please sign in to comment.