Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix invalid memory access when reading colour maps #2974

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Fix invalid memory access when reading colour maps #2974

merged 1 commit into from
Aug 21, 2024

Commits on Aug 21, 2024

  1. Fix invalid memory access when reading colour maps 

    In 6286158, as part of #2911,
ColourMap::maps was converted from a null-terminated C array to a
std::vector. However, the loops iterating over this list weren't updated
and were still relying on null-termination causing an invalid memory
access. This also resulted mrview crashing on MacOS.
    @daljit46
    daljit46 committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    ee8def6 View commit details
    Browse the repository at this point in the history