Fix invalid memory access when reading colour maps #2974
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6286158, as part of #2911,
ColourMap::maps
was converted from a null-terminated C array to astd::vector
. However, the loops iterating over this list weren't updated and were still relying on null-termination causing an invalid memory access. This also resultedmrview
crashing on MacOS.@bjeurissen Could you check if this fixes the crash on your system?