Fix invalid memory access when reading colour maps #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daljit46
force-pushed
the
fix_invalid_mem_access
branch
from
592b8f5
to
e2d81f2
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
daljit46
force-pushed
the
fix_invalid_mem_access
branch
from
e2d81f2
to
ee8def6
Compare
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Mentioning this for bookkeeping: the changes in this PR have been rebased in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 6286158, as part of #2911,
ColourMap::mapswas converted from a null-terminated C array to astd::vector. However, the loops iterating over this list weren't updated and were still relying on null-termination causing an invalid memory access. This also resultedmrviewcrashing on MacOS.@bjeurissen Could you check if this fixes the crash on your system?