Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nav2 compatible #51

Merged
merged 7 commits into from
Aug 11, 2024
Merged

Nav2 compatible #51

merged 7 commits into from
Aug 11, 2024

Conversation

finani
Copy link
Contributor

@finani finani commented Aug 11, 2024

This PR is about #49

I will close the issue after it is merged.

Test Environment

OS ROS
Ubuntu 20.04 noetic
Ubuntu 22.04 humble

nav2 compatible

  • ROS1 graph (mvsim only with namespace)
    2robots_ros1_graph

  • ROS2 graph (mvsim only with namespace)
    2robots_ros2_graph

add teleop panel (ros2)

@jlblancoc
Copy link
Member

I checked the changes and they LGTM, and run it on ros2 and the updated 2-robots demo works with two instances of RViz, so I'm just merging it...
Thanks @finani for the great contribution! 👍
If you have time for a corresponding demo update in the mvsim-nav2-demo repo it would be surely useful for future users.

@jlblancoc jlblancoc merged commit ef02d69 into MRPT:develop Aug 11, 2024
5 checks passed
@finani finani deleted the nav2-compatible branch August 11, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants