Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ros1 (tf/tf_static) #47

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Support ros1 (tf/tf_static) #47

merged 2 commits into from
Aug 6, 2024

Conversation

finani
Copy link
Contributor

@finani finani commented Aug 6, 2024

Commits

  • ros1 support

    • I updated to support ros1.
    • I tested on Ubuntu 20.04(noetic) and Ubuntu 22.04(humble).

  • Same fame id(each namespace)

    • Nav2's policy is to keep frame id and control only by topic name(namespace). related PR
    • So I changed frame id of each topic to be the same. (It only applies to /<Ri>/tf)

@jlblancoc
Copy link
Member

Awesome thanks.

If you have any ideas on pull requests to improve these examples in this repo for mvsim+Nav2, it would be more than welcome!

https://github.com/mrpt-ros-pkg/mvsim_nav2_demos

@jlblancoc jlblancoc merged commit 79fb822 into MRPT:develop Aug 6, 2024
5 checks passed
@finani finani deleted the support-ros1 branch August 7, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finani @jlblancoc