Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 2 #32

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Patch 2 #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c87ebcf
Create requirements.txt
miqueet Jul 24, 2018
12375fb
Update README.md
miqueet Jul 24, 2018
501e526
Merge pull request #1 from Wheaties466/patch-3
miqueet Jul 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,6 +293,8 @@ Create a new one with
#### Q3 - I need a diagram with less proprietary information. Can I get one without IPs or serial numbers?
You can change the text inside each node by editing the config option `diagram\node_text`. Below is an example that would produce a minimal information diagram:

# Install dependencies with pip -r requirements.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Install dependencies with pip -r requirements.txt
# Install dependencies with pip install -r requirements.txt


```
"diagram" : {
node_text = '<font point-size="10"><b>{node.name}</b></font><br />{node.ios}<br />{node.plat}'
Expand Down
9 changes: 9 additions & 0 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
graphviz==0.8.4
netaddr==0.7.19
ply==3.11
pyasn1==0.4.3
pycryptodomex==3.6.4
pydot==1.2.4
pyparsing==2.2.0
pysmi==0.3.1
pysnmp==4.4.4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinning requirements to releases is problematic as it may lead to installation issues.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think # Install dependencies with pip -r requirements.txt should be # Install dependencies with pip install -r requirements.txt