Patch 2 #32
Open
Patch 2 #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make it easier to install the requirements for the project.
should have requirement updated with each release, easier enviroment version control.
Update README.md
|
should make it easier to install required files as long as it is kept up to date. |
fabaff
reviewed
Mar 24, 2019
| pydot==1.2.4 | ||
| pyparsing==2.2.0 | ||
| pysmi==0.3.1 | ||
| pysnmp==4.4.4 |
There was a problem hiding this comment.
Pinning requirements to releases is problematic as it may lead to installation issues.
There was a problem hiding this comment.
I think # Install dependencies with pip -r requirements.txt should be # Install dependencies with pip install -r requirements.txt
fabaff
reviewed
Dec 10, 2020
| @@ -293,6 +293,8 @@ Create a new one with | |||
| #### Q3 - I need a diagram with less proprietary information. Can I get one without IPs or serial numbers? | |||
| You can change the text inside each node by editing the config option `diagram\node_text`. Below is an example that would produce a minimal information diagram: | |||
|
|
|||
| # Install dependencies with pip -r requirements.txt | |||
There was a problem hiding this comment.
Suggested change
| # Install dependencies with pip -r requirements.txt | |
| # Install dependencies with pip install -r requirements.txt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.