Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: issues with font size #3389

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Table: issues with font size #3389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 13 additions & 14 deletions src/components/table/partial-styles/_row-selection.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,34 +2,34 @@

// .has-rowselector {} // Mabe useful later

$checkbox-distance-to-left-edge: 0.5rem;

.select-all,
.limel-table--row-selector {
--mdc-checkbox-touch-target-size: 1.125rem; // prevent the checkbox affecting the row height
limel-checkbox {
min-height: 1.125rem;
}
// prevent the checkbox affecting the row height
--mdc-checkbox-touch-target-size: 1.125rem;
--mdc-checkbox-ripple-size: 2.5rem;
}

.select-all {
position: absolute;
z-index: $table--limel-table--row-selector;
left: 0;
left: $checkbox-distance-to-left-edge;
top: functions.pxToRem(6);
width: functions.pxToRem(41); // width of the selector column

display: flex !important;
align-items: center;
justify-content: center;
}

.limel-table--row-selector {
position: sticky !important; // otherwise will be overwritten from `.tabulator-row .tabulator-cell`
left: 0;
border-width: 0;
justify-content: center;
z-index: $table--limel-table--row-selector;
padding-right: 0 !important;
padding-left: 0 !important;

text-overflow: unset !important; // Otherwise a `…` will be rendered besides the checkbox, since we truncate all cells
padding-left: $checkbox-distance-to-left-edge !important;

limel-checkbox {
margin-top: functions.pxToRem(1);
}

.tabulator-row-odd & {
background-image: linear-gradient(
Expand Down Expand Up @@ -66,7 +66,6 @@

limel-checkbox {
transition: opacity 0.2s ease;
align-self: center;
opacity: 0.3;

.tabulator-row:hover & {
Expand Down
3 changes: 0 additions & 3 deletions src/components/table/table.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,6 @@ $table--limel-table--row-selector: 1;
padding: $cell-padding;
padding-left: $cell-padding + $width-of-sorter-arrow;

display: inline-flex;
align-items: center;
min-height: inherit;

&[style*='text-align: right;'] {
Expand All @@ -140,7 +138,6 @@ $table--limel-table--row-selector: 1;
.tabulator-col,
.tabulator-cell {
max-width: var(--table-max-column-width, 40rem);
font-size: functions.pxToRem(13);
}

#tabulator-loader,
Expand Down
Loading