Table: issues with font size #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kiarokh
force-pushed
the
tabulator-row-text-size-issues
branch
from
4013255 to
b274e31
Compare
|
Documentation has been published to https://lundalogik.github.io/lime-elements/versions/PR-3389/ |
Befkadu1
reviewed
Jan 7, 2025
| @@ -66,7 +66,7 @@ | |||
|
|
|||
| limel-checkbox { | |||
| transition: opacity 0.2s ease; | |||
| align-self: center; | |||
| // align-self: center; | |||
There was a problem hiding this comment.
Let us remove this if not needed
Kiarokh
force-pushed
the
tabulator-row-text-size-issues
branch
from
1e01d17 to
c1c7232
Compare
Kiarokh
commented
Jan 9, 2025
src/components/table/table.scss
Outdated
| @@ -99,7 +99,7 @@ $table--limel-table--row-selector: 1; | |||
|
|
|||
| .tabulator-row { | |||
| transition: background-color 0.2s ease; | |||
| min-height: 2.25rem; | |||
| height: 2.25rem; | |||
There was a problem hiding this comment.
I will drop this commit, since it's not needed for this PR, and I am worried that it creates more mess in future. It's a little bit of a breaking change.
For the records, I just keep this note here 👇 :
fix(table): avoid row height change
Sometimes, re-renderings after the initial render, or
changes within components in the table cells, or
clicking on rows, or size of the components in the
table cells would cause a resize on all rows in a table.
This always resulted in reduced quality of the experience.
This fix might break some carelessly designed UIs of
custom components used in table views.
But since we have so many issues with this,
and fixing other issues relies on having a fixed row height,
consumers have to adapt.
```
c1c7232 to
eb46a99
Compare
Kiarokh
changed the title
Kiarokh
changed the title
|
I tested, only what I could find is limel-chip is rendered in a bit weird way. too close to bottom. 
|
LucyChyzhova
approved these changes
Jan 10, 2025
In some scenarios, a table cell could suddenly get a really large font-size. Seemingly this happened when for contents with many characters. However, the issue was not the `font-size` property itself. It was likely due to some Safari-related bug, which had to do with `display: inline-flex` of table cells, and or combination of it with some other styles in Tabulator. Usage of `inline-flex` also caused text not to be truncated in any cells. Both problems are fixed now.
Kiarokh
force-pushed
the
tabulator-row-text-size-issues
branch
from
eb46a99 to
6b5aa05
Compare
|
🎉 This PR is included in version 37.79.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix https://github.com/Lundalogik/crm-feature/issues/4028
💡 How to test this PR
To see this issue, you need to find the right table that makes these random font-sizes.
%limebbin the input field and pressing ENTER.Review:
Browsers tested:
(Check any that applies, it's ok to leave boxes unchecked if testing something didn't seem relevant.)
Windows:
Linux:
macOS:
Mobile: