Raytracing: Shader-group-handle mapping #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- required for binding-table mapping/translation
|
CI gfxreconstruct build queued with queue ID 244873. |
|
CI gfxreconstruct build # 4705 running. |
|
CI gfxreconstruct build # 4705 failed. |
- copy-able, comparable, hash-able, no heap allocation required
fabian-lunarg
force-pushed
the
fabian_rt_extract_group_handle_info
branch
from
7383e17
to
426be23
Compare
|
CI gfxreconstruct build queued with queue ID 244893. |
|
CI gfxreconstruct build # 4706 running. |
|
CI gfxreconstruct build # 4706 failed. |
fabian-lunarg
commented
Aug 28, 2024
|
CI gfxreconstruct build queued with queue ID 244965. |
|
CI gfxreconstruct build # 4709 running. |
|
CI gfxreconstruct build # 4709 passed. |
|
the PR belongs to this issue: #1526 |
nickdriscoll-lunarg
approved these changes
Aug 29, 2024
|
thank you @nickdriscoll-lunarg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shader_group_handle_t) that can be compared and hashed (-> can be used as key in std::unordered_map)decode::PipelineInfoto map from capture- to replay-time handles.this matches @bradgrantham-lunarg's proof-of-concept, fleshing out some details, but please note:
no re-mapping is actually added/performed (that part of the proof-of-concept was still too hacky).
so this PR is only a necessary stepping-stone and should not change GFXR's behavior in any way.