Rebase and refactor fix for staging buffer memory types #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue with erroneous memory type selection when binding buffer memory without memory translation, e.g. in cases of binding replay staging buffers. Currently, the code retrieves the capture device's memory types, even though we want to bind the memory directly from the replay device. This issue led to various replay issues with mapping memory later on in the replay, and was particularly disruptive when attempting to replay a trimmed capture on a machine with a GPU of a different vendor than the capture system.
|
CI gfxreconstruct build queued with queue ID 2504. |
|
CI gfxreconstruct build # 2898 running. |
|
CI gfxreconstruct build # 2898 passed. |
bradgrantham-lunarg
changed the title
bradgrantham-lunarg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #1115