Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binpacking with flat networks. #550

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

thebracket
Copy link
Collaborator

Fixes binpacking circuits for flat networks.

@thebracket thebracket added the bug Something isn't working label Sep 5, 2024
@thebracket thebracket self-assigned this Sep 5, 2024
Copy link
Collaborator

@interduo interduo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested! binpacking is working again in "flat network design", thanks a lot

before:
image

after:
image


#[pyfunction]
pub fn is_network_flat() -> PyResult<bool> {
Ok(lqos_config::NetworkJson::load().unwrap().get_nodes_when_ready().len() == 1)
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github suggests "no new line at the end of file".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants