Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_{rust,dpkg}.sh - scripts rework fixes/simplifications #505

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

interduo
Copy link
Collaborator

@interduo interduo commented Jul 1, 2024

Some small improvements/bugfixes:

  • merge mkdir in one command,
  • use cat << EOF construction instead many echo'es,
  • merge systemctl calls in one cmds,
  • remove unneded loop,
  • other minor things found when running ./bash -x build_rust.sh or ./bash -x build_dpkg.sh
    (doubled files, bad compare operator for strings)
  • run python dependencies install instead only printing command,
  • uninstall script remove services unit files,
  • uninstall script mods: remove doubled clean/uninstall script,
  • firstly stop then disable services when uninstalling,
  • fix python lib alias after installing libreqos (postinst script) not in build_dpkg.sh script,
  • add quiet mode to pip install,
  • merge setting attrs for postinst postrm scripts
  • supress popd cmd messages,
  • fixes showing ip in motd,
  • use one command instead of two when disabling/enabling with stop,

@interduo interduo force-pushed the patch-33 branch 3 times, most recently from 2b068bd to 5e22b08 Compare July 1, 2024 12:59
@interduo interduo requested a review from thebracket July 1, 2024 12:59
@thebracket thebracket added the enhancement New feature or request label Jul 9, 2024
@thebracket thebracket added this to the v1.5 Beta 2 milestone Jul 9, 2024
@thebracket
Copy link
Collaborator

Tagging this for beta 2. I'll try and get it merged locally and tested today. I generally prefer keeping build scripts an obvious "one step at a time", so I may break some things out again for clarity (the build script is something you run pretty infrequently if you aren't actively working on the back-end, so it's a pretty low priority)

@interduo
Copy link
Collaborator Author

interduo commented Jul 9, 2024

For me lqos is mostly backend. I logged into GUI few times only. This means that its doing its work like a charm :)

@interduo interduo changed the title build_{rust,dpkg}.sh - scripts simplifications build_{rust,dpkg}.sh - scripts rework fixes/simplifications Jul 11, 2024
@interduo
Copy link
Collaborator Author

interduo commented Jul 12, 2024

ok - now I see nothing to improve/clean, waiting for review+squash&merge,

@interduo
Copy link
Collaborator Author

Now it looks much more professional without unneeded messages:
image

@interduo
Copy link
Collaborator Author

@thebracket did You checked this PR? It would be awesome if we could have this in beta2

@interduo
Copy link
Collaborator Author

interduo commented Aug 2, 2024

@thebracket could we merging this now? it takes much minutes to resolve conflicts...

@interduo
Copy link
Collaborator Author

@thebracket when will You do review? This is resolving few problems whitch users were asking on chat in last week.

@interduo
Copy link
Collaborator Author

interduo commented Sep 6, 2024

@thebracket what about merging this and bugfix #550 and release new beta?

This is the state - I tested much on prod with very heavy load.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants