Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make motions live #541

Merged
merged 16 commits into from
Mar 1, 2024
Merged

Make motions live #541

merged 16 commits into from
Mar 1, 2024

Conversation

miabonardi
Copy link
Contributor

Make motions live

Fix #418
Fix #419
Fix #465
Fix #507
Fix #508
Fix #539

Update #5
Update #6
Update #303

In this PR, I have:

  • Manually tested to ensure my PR is working
  • Ensured issues that this PR closes will be automatically closed
  • Requested review from Mia or Quinten
  • Ensured automated tests are passing
  • Updated automated tests so they are now passing
  • There were no automated tests on this repo so I filled out this interview and there is now an "it runs" test

Copy link
Collaborator

@tobyfey tobyfey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks amazing!
A few small things

  • the edit answers on the download page points to the eviction answer review screen and not the motion review screen
  • two questions defining trial_date allows you to set trial date and later be asked if there is a trial date (and typo in one trial_date question - iis)

@miabonardi
Copy link
Contributor Author

Thank you @tobyfey. I really appreciate your thorough review.

@nonprofittechy nonprofittechy merged commit 5cfae1c into main Mar 1, 2024
1 check passed
@nonprofittechy nonprofittechy deleted the make_motions_live branch July 23, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants