Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add safety margin to estimated fees for hedera #7790

Conversation

Sheng-Long
Copy link
Contributor

@Sheng-Long Sheng-Long commented Sep 10, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Should allow more flexibility around changing fee estimates for "Send Max"

πŸ“ Description

Add safety margin to Hedera fee estimates

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Sep 10, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Sep 10, 2024 5:56pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 5:56pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 5:56pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 10, 2024 5:56pm

Copy link

vercel bot commented Sep 10, 2024

@Sheng-Long is attempting to deploy a commit to the LedgerHQ Team on Vercel.

A member of the Team first needs to authorize it.

@live-github-bot live-github-bot bot added common Has changes in live-common fork Pull request base branch comes from a fork. labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common fork Pull request base branch comes from a fork.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants