Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIVE-12535 fix: add safety margin to estimated fees for hedera #7798

Merged
merged 2 commits into from
Sep 13, 2024
Merged

LIVE-12535 fix: add safety margin to estimated fees for hedera #7798

merged 2 commits into from
Sep 13, 2024

Conversation

Wozacosta
Copy link
Contributor

✅ Checklist

Checked out from #7790.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Add safety margin to Hedera fee estimates

❓ Context

  • JIRA or GitHub link: LIVE-12535

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 0:48am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 0:48am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 0:48am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 0:48am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Sep 13, 2024 0:48am

@live-github-bot live-github-bot bot added the common Has changes in live-common label Sep 11, 2024
@Wozacosta Wozacosta marked this pull request as ready for review September 12, 2024 09:07
@Wozacosta Wozacosta requested a review from a team as a code owner September 12, 2024 09:07
@Wozacosta Wozacosta merged commit e0536c5 into develop Sep 13, 2024
51 of 52 checks passed
@Wozacosta Wozacosta deleted the bugfix/hedera-margin-fees branch September 13, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedi-edelbloute hedi-edelbloute hedi-edelbloute approved these changes

Assignees

@Wozacosta Wozacosta

Labels
common Has changes in live-common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wozacosta @hedi-edelbloute @Sheng-Long