Delete participants automated test (plus other study related tests) #6732
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-klum
changed the title
labkey-klum
requested review from
labkey-bpatel,
labkey-tchad and
labkey-danield
and removed request for
labkey-bpatel
labkey-danield
approved these changes
Jun 6, 2025
labkey-tchad
approved these changes
Jun 6, 2025
study/src/org/labkey/study/model/ParticipantIdImportHelper.java
Outdated
Show resolved
Hide resolved
Comment on lines
188
to
200
| private void createDataset(Connection conn, String kindName, String datasetName, String folderName) throws Exception | ||
| { | ||
| CreateDomainCommand cmd = new CreateDomainCommand(kindName, datasetName); | ||
|
|
||
| cmd.getDomainDesign().setFields(List.of( | ||
| new FieldDefinition("Name", FieldDefinition.ColumnType.String), | ||
| new FieldDefinition("IntField", FieldDefinition.ColumnType.Integer), | ||
| new FieldDefinition("DoubleField", FieldDefinition.ColumnType.Double) | ||
| )); | ||
| if ("Demographics".equalsIgnoreCase(datasetName)) | ||
| cmd.setOptions(Map.of("demographics", true)); | ||
| cmd.execute(conn, folderName); | ||
| } |
There was a problem hiding this comment.
Consider making a DomainProps subclass for datasets (similar to ListDefinition or SampleTypeDefinition)
Might be useful when we start adding new SDMS tests.
There was a problem hiding this comment.
Good point, I was not aware of those classes. I'll take a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Adding automation for recent feature or bug fixes:
StudyManageParticipantsTestwhich was renamed from :StudyMergeParticipantsTest.