Introduce a subclass of DomainProps for Datasets #2483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-tchad
approved these changes
Jun 10, 2025
Comment on lines
+27
to
+30
| public static DatasetDefinition create(String name) | ||
| { | ||
| return new DatasetDefinition(name); | ||
| } |
There was a problem hiding this comment.
This static create method is a little confusing because DomainProps has a non-static create method that actually creates the domain.
There was a problem hiding this comment.
that's true, I was thinking of maybe init, not sure if there is a better verb.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Add to the existing list of domain helpers to manage
Datasetdomains. Refactor existing tests to use the new class.Related Pull Requests
LabKey/platform#6732