-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARKODE Stepper SetDefaults memory leak fix #560
Conversation
…tures before nullifying, and moved initial creation of the SUNAdaptController into stepper SetDefaults routines instead of arkCreate
Co-authored-by: Steven Roberts <[email protected]>
…as a NULL-valued SUNAdaptController
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the minor suggestion to remove an erroneous new line, do arkPrintAdaptMem
and arkAdapt
also need checks for a NULL
controller?
Co-authored-by: David Gardner <[email protected]>
The |
Updated stepper
SetDefaults
routines to deallocate pre-existing structures before nullifying, and moved initial creation of theSUNAdaptController
into stepperSetDefaults
routines instead ofarkCreate
. This allows non-adaptive steppers to leave the SUNAdaptController object unallocated.