Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feautre/adapt opt #565

Draft
wants to merge 51 commits into
base: feature/rk_defaults
Choose a base branch
from
Draft

Conversation

Steven-Roberts
Copy link
Collaborator

Draft status while doing performance comparisons.

This branches of offfeature/rk_defaults with feature/min-err merged in.

Current adaptivity controller changes:

  • No deadzone
  • Bias: 1.0
  • Safety factor: 0.9
  • Adjustment: 0
  • I controller for ARKStep and ERKStep (to be changed based on Sylvia’s testing)

src/arkode/arkode_arkstep_io.c Outdated Show resolved Hide resolved
src/arkode/arkode_erkstep_io.c Outdated Show resolved Hide resolved
src/arkode/arkode_io.c Show resolved Hide resolved
test/unit_tests/arkode/C_serial/ark_test_adapt.c Outdated Show resolved Hide resolved
test/unit_tests/arkode/C_serial/ark_test_adapt.c Outdated Show resolved Hide resolved
test/unit_tests/arkode/C_serial/ark_test_adapt.c Outdated Show resolved Hide resolved
Comment on lines +47 to +52
Removed error floors from the SUNAdaptController implementations which could
unnecessarily limit the time size growth, particularly after the first step.

On the first two time steps, the Soderlind controller uses an I controller
instead of omitting unavailable terms.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that these are "bug fixes" per-se. Should these be moved to "enhancements" section above?

Comment on lines +58 to +64
Removed error floors from the SUNAdaptController implementations which could
unnecessarily limit the time size growth, particularly after the first step.

On the first two time steps, the
:ref:`Soderlind controller <SUNAdaptController.Soderlind>` uses an I controller
instead of omitting unavailable terms.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that these are "bug fixes" per-se. Should these be moved to "enhancements" section above?

@balos1 balos1 added this to the SUNDIALS After Next milestone Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants