Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/persistent benchmarking #296

Merged
merged 185 commits into from
Aug 11, 2023
Merged

Conversation

yu-nix
Copy link
Collaborator

@yu-nix yu-nix commented Jul 3, 2023

Sets up the make target benchmark, which will allow the user to run all the benchmarks at once.

  • Adds a macro to add benchmarks to the target benchmark
  • Sets up output file structure for Caliper files to be saved to.

Adds documentation

  • how to build documentation
  • how to use SPOT
  • how to enable profiling of examples and benchmarks

Adds Adiak, a library to collect metadata

  • Used to collect TPL versions, compiler versions, and various other build data

@yu-nix
Copy link
Collaborator Author

yu-nix commented Jul 26, 2023

Added the file to scripts/shared

Copy link
Member

@balos1 balos1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few more minor items. I will look into the Lassen failure.

cmake/macros/SundialsAddBenchmark.cmake Outdated Show resolved Hide resolved
cmake/macros/SundialsAddBenchmark.cmake Show resolved Hide resolved
doc/shared/Install.rst Outdated Show resolved Hide resolved
@balos1
Copy link
Member

balos1 commented Jul 28, 2023

Benchmark job is failing here: https://lc.llnl.gov/gitlab/sundials/sundials/-/jobs/1348293. Looks like maybe we have the wrong version of radiuss-spack-configs?

@yu-nix
Copy link
Collaborator Author

yu-nix commented Jul 28, 2023

I think the cuda version needs to have +allow-unsupported-compilers. All the versions in the radiuss-spack-config have that variant.

@yu-nix yu-nix self-assigned this Jul 28, 2023
@balos1
Copy link
Member

balos1 commented Jul 31, 2023

@yu-nix

I think the cuda version needs to have +allow-unsupported-compilers. All the versions in the radiuss-spack-config have that variant.

That fixed the spack error. Now the job is failing when it gets to the benchmark step because it cannot find a directory. https://lc.llnl.gov/gitlab/sundials/sundials/-/jobs/1349618.

@balos1 balos1 merged commit cbae53e into develop Aug 11, 2023
14 checks passed
@balos1 balos1 deleted the feature/persistent-benchmarking branch August 11, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants